-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest - testMatch and testRegex cannot be used together with RN 0.59.1 #24060
Comments
You're using Btw, it seems like the Lines 33 to 36 in 02e8e53
pretty much aligns with the default from Jest 24: So soon enough we should be able to get rid of this from the config. To satisfy "working with TypeScript by default" constraint though, RN would need to require Jest 24+. @cpojer are we good to change it in 0.60 (I believe we are)? |
@thymikee yeah, the latest Jest 24 should be part of RN on master. |
Summary: Jest 24 includes [`testMatch` and `moduleFileExtensions`](https://github.com/facebook/jest/blob/c5fd7aae93764c13c259ae9a73846c10e84ae2a3/packages/jest-config/src/Defaults.ts#L70) that align with the ones that are currently there on master, because it added default handling for TypeScript as well. I think it's time for us to move to Jest 24. Is there a way we can tell users to upgrade Jest to certain version? Fixes #24060 [General] [Changed] - update Jest preset to align with Jest 24 Pull Request resolved: #24062 Differential Revision: D14538988 Pulled By: cpojer fbshipit-source-id: d8d152b8e8517b34144970f1cc1ed0b49f8b4e54
Summary: Jest 24 includes [`testMatch` and `moduleFileExtensions`](https://github.com/facebook/jest/blob/c5fd7aae93764c13c259ae9a73846c10e84ae2a3/packages/jest-config/src/Defaults.ts#L70) that align with the ones that are currently there on master, because it added default handling for TypeScript as well. I think it's time for us to move to Jest 24. Is there a way we can tell users to upgrade Jest to certain version? Fixes facebook/react-native#24060 [General] [Changed] - update Jest preset to align with Jest 24 Pull Request resolved: facebook/react-native#24062 Differential Revision: D14538988 Pulled By: cpojer fbshipit-source-id: d8d152b8e8517b34144970f1cc1ed0b49f8b4e54
🐛 Bug Report
I had project on 0.58.0 and upgraded to 0.59.1 and jest tests stopped working with an error
This is my jest configuration in package.json:
Nowhere do I have testMatch.
To Reproduce
Have 0.58 project and upgrade to 0.59.1
Expected Behavior
Tests to start running
Code Example
Environment
The text was updated successfully, but these errors were encountered: