Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hermes experimental debugger does not open on iOS with custom build configurations #43185

Closed
sliptype opened this issue Feb 23, 2024 · 5 comments
Labels

Comments

@sliptype
Copy link

Description

I have an iOS build configuration Staging.Debug that is a copy of Debug. The experimental debugger fails to launch when running this build configuration via:

react-native start --experimental-debugger

and

react-native run-ios --mode Staging.Debug

Output from metro:

info Launching JS debugger (experimental)...
warn No compatible apps connected. JavaScript debugging can only be used with the Hermes engine.

I've confirmed that the app is using Hermes:
image

The debugger launches properly when doing:

react-native run-ios --mode Debug

I did a little digging and see there is a check for the Debug configuration here and here, but I'm not sure if relevant.

Staging.Debug was created by copying Debug following these instructions. I would like to debug Staging.Debug because I need certain configuration for my staging app.

Steps to reproduce

  1. git clone [email protected]:sliptype/RNRepro1.git
  2. yarn i && pod install --project-directory=ios
  3. yarn start
  4. In another shell yarn ios
  5. Launch debug menu with CMD + D or Device > Shake
  6. Press Open Debugger

React Native Version

0.73.4

Affected Platforms

Runtime - iOS, Build - MacOS

Output of npx react-native info

System:
  OS: macOS 14.3.1
  CPU: (10) arm64 Apple M1 Max
  Memory: 142.52 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.17.0
    path: ~/.nvm/versions/node/v18.17.0/bin/node
  Yarn:
    version: 1.22.21
    path: ~/.nvm/versions/node/v18.17.0/bin/yarn
  npm:
    version: 9.6.7
    path: ~/.nvm/versions/node/v18.17.0/bin/npm
  Watchman:
    version: 2024.01.22.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/sebastian/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.2
      - iOS 17.2
      - macOS 14.2
      - tvOS 17.2
      - visionOS 1.0
      - watchOS 10.2
  Android SDK: Not Found
IDEs:
  Android Studio: 2021.3 AI-213.7172.25.2113.9014738
  Xcode:
    version: 15.2/15C500b
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.10
    path: /usr/bin/javac
  Ruby:
    version: 2.7.6
    path: /Users/sebastian/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.4
    wanted: 0.73.4
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

info Launching JS debugger (experimental)...
warn No compatible apps connected. JavaScript debugging can only be used with the Hermes engine.

Reproducer

https://github.com/sliptype/RNRepro1

Screenshots and Videos

No response

@github-actions github-actions bot added the Platform: iOS iOS applications. label Feb 23, 2024
@truongngodang
Copy link

same issues

@kmarushchakItomy
Copy link

Also experiencing this.
RN 0.73.5

@ayoubbahmad
Copy link

Same issues! when I add new schemes with custom build configurations

@sandeepsuthar
Copy link

Same issue while using custom configuration (Debug-QAT) with custom Scheme (QAT) but it's working as expected with Debug configuration.

jblarriviere added a commit to jblarriviere/react-native that referenced this issue Apr 2, 2024
This allows build configuration named like `StagingDebug` to match with settings applied to `Debug`
This fixes facebook#43185
@sternlucas
Copy link

sternlucas commented Apr 5, 2024

Same problem here. How can I fix this until the new version is released ?

cortinico pushed a commit that referenced this issue Apr 8, 2024
Summary:
This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes #43185

Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in #43185

This now applies the setting to every configuration ending with `Debug`

## Changelog:

[IOS] [CHANGED] - fix: build settings for custom build configuration

Pull Request resolved: #43780

Reviewed By: dmytrorykun

Differential Revision: D55688996

Pulled By: cipolleschi

fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
alfonsocj pushed a commit that referenced this issue Apr 12, 2024
Summary:
This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes #43185

Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in #43185

This now applies the setting to every configuration ending with `Debug`

## Changelog:

[IOS] [CHANGED] - fix: build settings for custom build configuration

Pull Request resolved: #43780

Reviewed By: dmytrorykun

Differential Revision: D55688996

Pulled By: cipolleschi

fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
douglowder pushed a commit to react-native-tvos/react-native-tvos that referenced this issue Apr 22, 2024
Summary:
This allows build configuration named like `StagingDebug` to match with settings applied to `Debug` This fixes facebook/react-native#43185

Custom build setting were only applied to `Debug` build configurations, preventing configurations named `StagingDebug` or similar to access the new experimental debugger, as reported in facebook/react-native#43185

This now applies the setting to every configuration ending with `Debug`

## Changelog:

[IOS] [CHANGED] - fix: build settings for custom build configuration

Pull Request resolved: facebook/react-native#43780

Reviewed By: dmytrorykun

Differential Revision: D55688996

Pulled By: cipolleschi

fbshipit-source-id: 1f34cd722f6acfaa08d3377e19a04d08af97ed7c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants