[Android] Headless Crash Tried to finish non-existent task with id

[RodolfoGS]

Description

Sometimes a headless task tries to finish, but it doesn’t exist, which causes an exception.
No one knows how to reliably reproduce it, as it could be a race condition. However, if you attempt to remove a task that has already been removed, it shouldn’t cause an issue since you're trying to remove something that’s already gone (which is exactly what you want).

Related:

• Android HeadlessJS Crash - Tried to finish non-existent task with id #33883
• Android HeadlessJS Crash - Tried to finish non-existent task with id #27597
• Android Crash - Tried to finish non-existent task with id 2 transistorsoft/react-native-background-fetch#202
• Fatal Exception: Tried to finish non-existent task with id 1 transistorsoft/react-native-background-fetch#369
• Tried to finish non-existent task with id x transistorsoft/react-native-background-geolocation#2096
• [Android] App crash scenario jpush/jpush-react-native#78

Pull Request

I created a PR to fix it.
PR: #46497

Steps to reproduce

I created an example where I attempt to remove a task that doesn’t exist.

Example: https://github.com/RodolfoGS/react-native-fix-non-existent-task

How to reproduce using the example above:

1. git clone [email protected]:RodolfoGS/react-native-fix-non-existent-task.git
2. cd react-native-fix-non-existent-task
3. npm install
4. npm run android
5. Notice the crash

Steps to create the example from scratch and reproduce the crash:

1. npx @react-native-community/cli@latest init AwesomeProject
2. cd AwesomeProject
3. Add call to finishTask to reproduce the crash (RodolfoGS/react-native-fix-non-existent-task@6fe3c13)
4. npm run android
5. Notice the crash

React Native Version

0.75.3

Affected Platforms

Runtime - Android

Output of npx react-native info

System:
  OS: macOS 14.5
  CPU: (8) arm64 Apple M1
  Memory: 96.44 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.15.1
    path: /usr/local/bin/node
  Yarn:
    version: 3.6.4
    path: /usr/local/bin/yarn
  npm:
    version: 10.7.0
    path: /usr/local/bin/npm
  Watchman:
    version: 2022.10.10.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /usr/local/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.5
      - iOS 17.5
      - macOS 14.5
      - tvOS 17.5
      - visionOS 1.2
      - watchOS 10.5
  Android SDK: Not Found
IDEs:
  Android Studio: 2024.1 AI-241.18034.62.2411.12071903
  Xcode:
    version: 15.4/15F31d
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.3.1
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.3.1
    wanted: 18.3.1
  react-native:
    installed: 0.75.3
    wanted: 0.75.3
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: Not found
  newArchEnabled: false

Stacktrace or Logs

Fatal Exception: java.lang.AssertionError: Tried to finish non-existent task with id 28.
  at com.facebook.infer.annotation.Assertions.assertCondition(Assertions.java:88)
  at com.facebook.react.jstasks.HeadlessJsTaskContext.finishTask(HeadlessJsTaskContext.java:179)
  at com.facebook.react.jstasks.HeadlessJsTaskContext$3.run(HeadlessJsTaskContext.java:217)
  at android.os.Handler.handleCallback(Handler.java:958)
  at android.os.Handler.dispatchMessage(Handler.java:99)
  at android.os.Looper.loopOnce(Looper.java:257)
  at android.os.Looper.loop(Looper.java:368)
  at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:233)
  at java.lang.Thread.run(Thread.java:1012)

Reproducer

https://github.com/RodolfoGS/react-native-fix-non-existent-task

Screenshots and Videos

Screen.Recording.2024-09-14.at.12.56.27.PM.mov

[mensonones]

in RodolfoGS/react-native-fix-non-existent-task@6fe3c13

You are calling HeadlessJsTaskContext.getInstance() without checking if reactNativeHost.reactInstanceManager.currentReactContext is available

if try this example

reactNativeHost.reactInstanceManager.currentReactContext?.let { reactContext ->
      val headlessJsTaskContext = HeadlessJsTaskContext.getInstance(reactContext)
      // Terminate the headless task if necessary
      headlessJsTaskContext.finishTask(123)
  } ?: run {
      // Handles the case where ReactContext is not yet available
  }

although the task does not exist, it does not break.

[RodolfoGS]

@mensonones your code works because reactNativeHost.reactInstanceManager.currentReactContext is null, so it never enters the first block and finishTask is not called

Try it with my code, or since currentReactContext is null and getInstance accepts it, you could pass null to getInstance, both cases will give the same result.

You could do this:

HeadlessJsTaskContext.getInstance(null).finishTask(123)

[cipolleschi]

Commit landed b4532ad