Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.23.0-rc1]Unable to resolve modules AssestRegistry when require image inside node_modules #6638

Closed
evollu opened this issue Mar 24, 2016 · 3 comments
Closed

[0.23.0-rc1]Unable to resolve modules AssestRegistry when require image inside node_modules #6638

evollu opened this issue Mar 24, 2016 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@evollu
Copy link

evollu commented Mar 24, 2016

I have code like
<Image source={require('react-native-router-flux/src/back_chevron.png')} style={{height: 100, width: 100}}/> in my app and it works fine in 0.22.2

but in 0.23.0-rc1 system throws "Unable to resolve modules AssestRegistry [path to back_chevron.png" in IOS, and "Requireing unknown module "AssestRegistry"" in Android
@evollu evollu closed this as completed Mar 24, 2016
@evollu evollu reopened this Mar 24, 2016
@bestander bestander mentioned this issue Mar 25, 2016
Closed
9 tasks
@giacomorebonato giacomorebonato mentioned this issue Mar 27, 2016
Closed
@RWOverdijk
Copy link

👍

@philipshurpik
Copy link

Confirm - if require image inside project - it works
If image is required in library (that is placed in node_modules) - not working

This was referenced Mar 31, 2016
Closed
Closed
@mkonicek
Copy link
Contributor

Might be caused by 06b5bda.

ETA for a fix next week.

@ide ide mentioned this issue Apr 4, 2016
Closed
4 tasks
bestander added a commit to bestander/react-native that referenced this issue Apr 5, 2016
@bestander
Fixed images required from node_modules
01d8928 
This fixes facebook#6638
@bestander bestander mentioned this issue Apr 5, 2016
Closed
@ghost ghost closed this as completed in d0566d8 Apr 6, 2016
mkonicek pushed a commit that referenced this issue Apr 6, 2016
@bestander
Fixed images required from node_modules
a5b95d5 
Summary:This fixes #6638 by resolving AssetRegistry relatively.
Closes #6822

Reviewed By: davidaurelio

Differential Revision: D3144463

Pulled By: bestander

fb-gh-sync-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
fbshipit-source-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
ide pushed a commit that referenced this issue Apr 6, 2016
@bestander @ide
Fixed images required from node_modules
d5fa599 
Summary:This fixes #6638 by resolving AssetRegistry relatively.
Closes #6822

Reviewed By: davidaurelio

Differential Revision: D3144463

Pulled By: bestander

fb-gh-sync-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
fbshipit-source-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
zebulgar pushed a commit to nightingale/react-native that referenced this issue Jun 18, 2016
@bestander @zebulgar
Fixed images required from node_modules
79f3d46 
Summary:This fixes facebook#6638 by resolving AssetRegistry relatively.
Closes facebook#6822

Reviewed By: davidaurelio

Differential Revision: D3144463

Pulled By: bestander

fb-gh-sync-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
fbshipit-source-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
cpojer pushed a commit to facebook/metro that referenced this issue Jan 26, 2017
@bestander
Fixed images required from node_modules
6f9aad3 
Summary:This fixes facebook/react-native#6638 by resolving AssetRegistry relatively.
Closes facebook/react-native#6822

Reviewed By: davidaurelio

Differential Revision: D3144463

Pulled By: bestander

fb-gh-sync-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
fbshipit-source-id: d3eeb24ae9e08a32f742c50ae5f0314fd33d1b6b
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed images required from node_modules bestander/react-native
5 participants
@mkonicek @RWOverdijk @philipshurpik @evollu @react-native-bot