Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ScrollView] Provide a way to set ScrollView's scrollIndicatorInsets separately from the contentInset #745

Closed
ide opened this issue Apr 8, 2015 · 5 comments · May be fixed by AbhinavJain13/react-native#41
Closed

[ScrollView] Provide a way to set ScrollView's scrollIndicatorInsets separately from the contentInset #745

ide opened this issue Apr 8, 2015 · 5 comments · May be fixed by AbhinavJain13/react-native#41
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Apr 8, 2015

I'm building a refreshable scroll view and this is one of the missing pieces. When the refresh indicator is visible, I increase the top contentInset but want the scrollIndicatorInset to stay the same. Implementing this is probably easy but I would like to solicit API ideas since insets are tricky because of automaticallyAdjustContentInsets.
@brentvatne brentvatne changed the title Provide a way to set ScrollView's scrollIndicatorInsets separately from the contentInset [ScrollView] Provide a way to set ScrollView's scrollIndicatorInsets separately from the contentInset May 31, 2015
@rjchatfield
Copy link

+1

1 similar comment
@liuda101
Copy link

+1

@sahrens
Copy link
Contributor

sahrens commented Jul 17, 2015

hmm, I don't have any clever ideas....maybe just a bool coupleContentAndIndicatorOffsets?

@ericvicenti
Copy link
Contributor

@ide, if you want to make a quick example playground to demo this issue, it might make a goodfirsttask

@EwanThomas EwanThomas mentioned this issue Nov 18, 2015
Closed
ghost pushed a commit that referenced this issue Nov 19, 2015
UIRefreshControl added to scroll view
2faf863 
Summary: **What:**

adds `onRefreshStart` property to `ScrollView.js` for displaying and activating pull to refresh.

**Why:**

Javascript implementations seemed a little flakey and inconsistent.  As you can see in the issues below:

#2356
#745

So this is an attempt a completely native implementation.

What do you think?

![Image of dog](http://i.imgur.com/HcTQnzJ.gif)
Closes #4205

Reviewed By: svcscm

Differential Revision: D2674945

Pulled By: nicklockwood

fb-gh-sync-id: 65113a5db9785df5a95c68323c2cdf19f3b217b1
sunnylqm pushed a commit to sunnylqm/react-native that referenced this issue Dec 2, 2015
@sunnylqm
UIRefreshControl added to scroll view
8a397dc 
Summary: **What:**

adds `onRefreshStart` property to `ScrollView.js` for displaying and activating pull to refresh.

**Why:**

Javascript implementations seemed a little flakey and inconsistent.  As you can see in the issues below:

facebook#2356
facebook#745

So this is an attempt a completely native implementation.

What do you think?

![Image of dog](http://i.imgur.com/HcTQnzJ.gif)
Closes facebook#4205

Reviewed By: svcscm

Differential Revision: D2674945

Pulled By: nicklockwood

fb-gh-sync-id: 65113a5db9785df5a95c68323c2cdf19f3b217b1
machard pushed a commit to machard/react-native that referenced this issue Dec 10, 2015
@machard
UIRefreshControl added to scroll view
e7f5adb 
Summary: **What:**

adds `onRefreshStart` property to `ScrollView.js` for displaying and activating pull to refresh.

**Why:**

Javascript implementations seemed a little flakey and inconsistent.  As you can see in the issues below:

facebook#2356
facebook#745

So this is an attempt a completely native implementation.

What do you think?

![Image of dog](http://i.imgur.com/HcTQnzJ.gif)
Closes facebook#4205

Reviewed By: svcscm

Differential Revision: D2674945

Pulled By: nicklockwood

fb-gh-sync-id: 65113a5db9785df5a95c68323c2cdf19f3b217b1
Crash-- pushed a commit to Crash--/react-native that referenced this issue Dec 24, 2015
@Crash--
UIRefreshControl added to scroll view
64714a4 
Summary: **What:**

adds `onRefreshStart` property to `ScrollView.js` for displaying and activating pull to refresh.

**Why:**

Javascript implementations seemed a little flakey and inconsistent.  As you can see in the issues below:

facebook#2356
facebook#745

So this is an attempt a completely native implementation.

What do you think?

![Image of dog](http://i.imgur.com/HcTQnzJ.gif)
Closes facebook#4205

Reviewed By: svcscm

Differential Revision: D2674945

Pulled By: nicklockwood

fb-gh-sync-id: 65113a5db9785df5a95c68323c2cdf19f3b217b1
@brentvatne
Copy link
Collaborator

Hi there! This issue is being closed because it has been inactive for a while.

But don't worry, it will live on with ProductPains! Check out it's new home: https://productpains.com/post/react-native/scrollview-provide-a-way-to-set-scrollviews-scrollindicatorinsets-separately-from-the-contentinset

@facebook facebook locked as resolved and limited conversation to collaborators Jul 23, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Fix for 1 vulnerabilities AbhinavJain13/react-native
7 participants
@brentvatne @ide @liuda101 @ericvicenti @sahrens @rjchatfield @react-native-bot