Fix babelHelpers.typeof is not a function #11093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @yungsters to be a potential reviewer. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
For other who had this packager error: I was having this issue due to a symlinked module that has it's own .babelrc and is not transformed. The module's babelrc specifies This PR change resolved the issue for me, would love to see this merged! |
|
What does it take to get this PR merged? |
|
Thanks @cmcewen, this problem has been popping up all the time |
|
@cmcewen Anything we can do to help get this merged? |
|
I'm not sure - looks like @janicduplessis did some work on this file a while back? |
ide
suggested changes
Dec 19, 2016
| babelHelpers.typeof = typeof Symbol === "function" && typeof Symbol.iterator === "symbol" ? function (obj) { | ||
| return typeof obj; | ||
| } : function (obj) { | ||
| return obj && typeof Symbol === "function" && obj.constructor === Symbol ? "symbol" : typeof obj; |
There was a problem hiding this comment.
Can you add an obj !== Symbol.prototype comparison too? See https://github.com/babel/babel/blob/master/packages/babel-helpers/src/helpers.js#L8
|
@facebook-github-bot shipit |
ide
approved these changes
Dec 20, 2016
mikelambert
pushed a commit
to mikelambert/react-native
that referenced
this pull request
Dec 24, 2016
Summary: We started encountering the error described in facebook#5747 (`babelHelpers.typeof is not a function) after switching from npm to yarn. [This comment](facebook#5747 (comment)) led to [this comment](facebook#4844 (comment)) which contains a solution we've been using successfully in our production app. Maybe I didn't look in the right place but it doesn't seem anyone had actually PR'd this change before (if so and I didn't find it, I apologize). An alternative solution it seems is to add a [different .babelrc](http://stackoverflow.com/questions/35563025/new-react-native-app-has-typeerror-babelhelpers-typeof-is-not-a-function-ios), but this seems easier to me. Closes facebook#11093 Differential Revision: D4353977 fbshipit-source-id: 3e45de29ef5d0e046219a32df6530dcf838b9fd9
nicktate
pushed a commit
to nicktate/react-native
that referenced
this pull request
Dec 30, 2016
Summary: We started encountering the error described in facebook#5747 (`babelHelpers.typeof is not a function) after switching from npm to yarn. [This comment](facebook#5747 (comment)) led to [this comment](facebook#4844 (comment)) which contains a solution we've been using successfully in our production app. Maybe I didn't look in the right place but it doesn't seem anyone had actually PR'd this change before (if so and I didn't find it, I apologize). An alternative solution it seems is to add a [different .babelrc](http://stackoverflow.com/questions/35563025/new-react-native-app-has-typeerror-babelhelpers-typeof-is-not-a-function-ios), but this seems easier to me. Closes facebook#11093 Differential Revision: D4353977 fbshipit-source-id: 3e45de29ef5d0e046219a32df6530dcf838b9fd9
mikelambert
pushed a commit
to mikelambert/react-native
that referenced
this pull request
Jan 4, 2017
Summary: We started encountering the error described in facebook#5747 (`babelHelpers.typeof is not a function) after switching from npm to yarn. [This comment](facebook#5747 (comment)) led to [this comment](facebook#4844 (comment)) which contains a solution we've been using successfully in our production app. Maybe I didn't look in the right place but it doesn't seem anyone had actually PR'd this change before (if so and I didn't find it, I apologize). An alternative solution it seems is to add a [different .babelrc](http://stackoverflow.com/questions/35563025/new-react-native-app-has-typeerror-babelhelpers-typeof-is-not-a-function-ios), but this seems easier to me. Closes facebook#11093 Differential Revision: D4353977 fbshipit-source-id: 3e45de29ef5d0e046219a32df6530dcf838b9fd9
DanielMSchmidt
pushed a commit
to DanielMSchmidt/react-native
that referenced
this pull request
Jan 4, 2017
Summary: We started encountering the error described in facebook#5747 (`babelHelpers.typeof is not a function) after switching from npm to yarn. [This comment](facebook#5747 (comment)) led to [this comment](facebook#4844 (comment)) which contains a solution we've been using successfully in our production app. Maybe I didn't look in the right place but it doesn't seem anyone had actually PR'd this change before (if so and I didn't find it, I apologize). An alternative solution it seems is to add a [different .babelrc](http://stackoverflow.com/questions/35563025/new-react-native-app-has-typeerror-babelhelpers-typeof-is-not-a-function-ios), but this seems easier to me. Closes facebook#11093 Differential Revision: D4353977 fbshipit-source-id: 3e45de29ef5d0e046219a32df6530dcf838b9fd9
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: We started encountering the error described in #5747 (`babelHelpers.typeof is not a function) after switching from npm to yarn. [This comment](facebook/react-native#5747 (comment)) led to [this comment](facebook/react-native#4844 (comment)) which contains a solution we've been using successfully in our production app. Maybe I didn't look in the right place but it doesn't seem anyone had actually PR'd this change before (if so and I didn't find it, I apologize). An alternative solution it seems is to add a [different .babelrc](http://stackoverflow.com/questions/35563025/new-react-native-app-has-typeerror-babelhelpers-typeof-is-not-a-function-ios), but this seems easier to me. Closes facebook/react-native#11093 Differential Revision: D4353977 fbshipit-source-id: 3e45de29ef5d0e046219a32df6530dcf838b9fd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We started encountering the error described in #5747 (`babelHelpers.typeof is not a function) after switching from npm to yarn. This comment led to this comment which contains a solution we've been using successfully in our production app.
Maybe I didn't look in the right place but it doesn't seem anyone had actually PR'd this change before (if so and I didn't find it, I apologize).
An alternative solution it seems is to add a different .babelrc, but this seems easier to me.