Add newly recommended method for RCTLinkingManager due to deprecation #13615

jasonnoahchoi · 2017-04-21T18:55:04Z

Motivation

What existing problem does the pull request solve?

Beginning in iOS9, Apple has deprecated -application:openURL:sourceApplication:annotations:

- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url sourceApplication:(nullable NSString *)sourceApplication annotation:(id)annotation NS_DEPRECATED_IOS(4_2, 9_0, "Please use application:openURL:options:") __TVOS_PROHIBITED;

This PR uses the newly recommended method:

- (BOOL)application:(UIApplication *)app openURL:(NSURL *)url options:(NSDictionary<UIApplicationOpenURLOptionsKey, id> *)

while meanwhile, leaving the deprecated one for developers wishing to use the older -application:openURL:sourceApplication:annotations: for apps that support versions 8.x or less.

Benefits will include:

less warnings
official deprecation should happen when iOS 11 is deployed
TVOS support

jasonnoahchoi · 2017-04-21T19:03:15Z

Libraries/LinkingIOS/RCTLinkingManager.m

+            openURL:(NSURL *)URL
+            options:(NSDictionary<UIApplicationOpenURLOptionsKey,id> *)options {
+    [self postNotificationWithURL:URL];
+    return YES;


decided to leave in return YES to be distinctly clear that this class function is returning a BOOL

javache · 2017-04-27T08:10:47Z

Examples/UIExplorer/UIExplorer/AppDelegate.m

@@ -60,6 +60,11 @@ - (NSURL *)sourceURLForBridge:(__unused RCTBridge *)bridge
                                                        fallbackResource:nil];
 }

+- (BOOL)application:(UIApplication *)app openURL:(NSURL *)url


put openURL on a new line

javache · 2017-04-27T08:11:05Z

Libraries/Linking/Linking.js

 * - (BOOL)application:(UIApplication *)application openURL:(NSURL *)url
 *   sourceApplication:(NSString *)sourceApplication annotation:(id)annotation
 * {
 *   return [RCTLinkingManager application:application openURL:url
 *                       sourceApplication:sourceApplication annotation:annotation];
 * }
 *
+ * // For iOS versions supporting 9.x or greater
+ *
+ * - (BOOL)application:(UIApplication *)app openURL:(NSURL *)url


javache · 2017-04-27T08:11:57Z

Libraries/LinkingIOS/RCTLinkingManager.m

  return YES;
 }

+ (void)postNotificationWithURL:(NSURL *)URL


turn this into a C helper method void postNotificationWithURL(NSURL *URL)

@javache k updated, had to add id class; at the top because unable to call self in c function

javache · 2017-05-02T08:56:49Z

Libraries/LinkingIOS/RCTLinkingManager.m

@@ -14,13 +14,15 @@
 #import <React/RCTUtils.h>

 NSString *const RCTOpenURLNotification = @"RCTOpenURLNotification";
+id class;


Don't do this

javache · 2017-05-02T08:57:33Z

Libraries/LinkingIOS/RCTLinkingManager.m

+  return YES;
+}
+
+void postNotificationWithURL(NSURL *URL)


Instead pass self in here as and change the signature to postNotificationWithURL(id sender, NSURL *URL). Also mark this method as static.

@javache thanks for the feedback

facebook-github-bot · 2017-05-02T19:42:49Z

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot · 2017-05-03T08:48:19Z

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

facebook-github-bot · 2017-05-03T09:45:03Z

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

jasonnoahchoi · 2017-05-10T00:23:14Z

@javache merged the latest master branch into here to fix merge conflicts, anything else I need to do?

javache · 2017-05-10T09:11:09Z

We're currently having some issues importing pull requests in our internal systems. I'll comment here if any changes are required on your PR. Thanks!

javache · 2017-05-24T18:23:32Z

Can you rebase this? UIExplorer has been renamed to RNTester.

- update for true deprecation versions

jasonnoahchoi · 2017-05-25T16:09:23Z

ok @javache I've rebased it and made sure any new comments and updates are included. While it is technically correct that you can use -application:openURL:sourceApplication:annotations: for iOS 9, it's much safer to say that it is for iOS 8.x and older because the official deprecation announcement happened during the iOS 9 release. Please let me know if there are any questions or concerns regarding the rebase and PR.

facebook-github-bot · 2017-05-25T17:22:53Z

@javache has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

Summary: What existing problem does the pull request solve? Beginning in iOS9, Apple has deprecated `-application:openURL:sourceApplication:annotations:` `- (BOOL)application:(UIApplication *)application openURL:(NSURL *)url sourceApplication:(nullable NSString *)sourceApplication annotation:(id)annotation NS_DEPRECATED_IOS(4_2, 9_0, "Please use application:openURL:options:") __TVOS_PROHIBITED;` This PR uses the newly recommended method: `- (BOOL)application:(UIApplication *)app openURL:(NSURL *)url options:(NSDictionary<UIApplicationOpenURLOptionsKey, id> *)` while meanwhile, leaving the deprecated one for developers wishing to use the older `-application:openURL:sourceApplication:annotations:` for apps that support versions 8.x or less. Benefits will include: - [x] less warnings - [x] official deprecation should happen when iOS 11 is deployed - [x] TVOS support Closes facebook/react-native#13615 Differential Revision: D4987980 Pulled By: javache fbshipit-source-id: ae07715a55ca627860262a9c8cf7df1e3c5e752b

Summary: This sync includes the following changes: - **[d83601080](facebook/react@d83601080)**: Wrap retrySuspendedRoot using SchedulerTracing (#13776) //<Sophie Alpert>// - **[40a521aa7](facebook/react@40a521aa7)**: Terminology: Functional -> Function Component (#13775) //<Dan Abramov>// - **[605ab10a4](facebook/react@605ab10a4)**: Add envify transform to scheduler package (#13766) //<Michael Ridgway>// - **[acc7f404c](facebook/react@acc7f404c)**: Restart from root if promise pings before end of render phase (#13774) //<Andrew Clark>// - **[cbc224028](facebook/react@cbc224028)**: fix - small misspelling (#13768) //<Spencer Davies>// - **[4eabeef11](facebook/react@4eabeef11)**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>// - **[95a3e1c2e](facebook/react@95a3e1c2e)**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>// - **[96bcae9d5](facebook/react@96bcae9d5)**: Jest + test renderer helpers for concurrent mode (#13751) //<Andrew Clark>// - **[5c783ee75](facebook/react@5c783ee75)**: Remove unreachable code (#13762) //<Heaven>// - **[36c5d69ca](facebook/react@36c5d69ca)**: Always warn about legacy context within StrictMode tree (#13760) //<Brian Vaughn>// - **[3e9a5de88](facebook/react@3e9a5de88)**: UMD react-cache build (#13761) //<Maksim Markelov>// - **[8315a30b9](facebook/react@8315a30b9)**: --save is no longer needed (#13756) //<Joe Cortopassi>// - **[ce96e2df4](facebook/react@ce96e2df4)**: Rename simple-cache-provider to react-cache (#13755) //<Andrew Clark>// - **[c5212646f](facebook/react@c5212646f)**: Removed extra typeof checks for contextType.unstable_read (#13736) //<Brian Vaughn>// - **[806eebdae](facebook/react@806eebdae)**: Enable getDerivedStateFromError (#13746) //<Brian Vaughn>// - **[a0733fe13](facebook/react@a0733fe13)**: pure (#13748) //<Andrew Clark>// - **[4d17c3f05](facebook/react@4d17c3f05)**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>// - **[469005d87](facebook/react@469005d87)**: Revise `AttributeType` React Native Flow Type (#13737) //<Timothy Yung>// - **[0dc0ddc1e](facebook/react@0dc0ddc1e)**: Rename AsyncMode -> ConcurrentMode (#13732) //<Dominic Gannaway>// - **[7601c3765](facebook/react@7601c3765)**: Ensure "addEventListener" exists on "window" for "scheduler" package (#13731) //<Dominic Gannaway>// - **[d0c0ec98e](facebook/react@d0c0ec98e)**: Added a PureComponent contextType test (#13729) //<Brian Vaughn>// - **[4b68a6498](facebook/react@4b68a6498)**: Support class component static contextType attribute (#13728) //<Brian Vaughn>// - **[f305d2a48](facebook/react@f305d2a48)**: [scheduler] Priority levels, continuations, and wrapped callbacks (#13720) //<Andrew Clark>// - **[970a34bae](facebook/react@970a34bae)**: Bump babel-eslint and remove flow supressions (#13727) //<Brian Ng>// - **[13965b4d3](facebook/react@13965b4d3)**: Interaction tracking ref-counting bug fixes (WIP) (#13590) //<Brian Vaughn>// - **[17e703cb9](facebook/react@17e703cb9)**: Restore global window.event after event dispatching (#13688) (#13697) //<Sergei Startsev>// - **[a775a767a](facebook/react@a775a767a)**: Remove redundant logic (#13502) //<Heaven>// - **[e1a067dea](facebook/react@e1a067dea)**: Fix circular dependency in TracingSubscriptions (#13689) //<Maksim Markelov>// - **[518812eeb](facebook/react@518812eeb)**: Clarify comment (#13684) //<Heaven>// - **[eeb817785](facebook/react@eeb817785)**: Remove some old files from stats //<Dan>// - **[7ea3ca1d1](facebook/react@7ea3ca1d1)**: Rename schedule to scheduler (#13683) //<Dan Abramov>// - **[bec2ddaf1](facebook/react@bec2ddaf1)**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>// - **[4269fafb0](facebook/react@4269fafb0)**: Updating package versions for release 16.5.2 //<Brian Vaughn>// - **[4380f9ba1](facebook/react@4380f9ba1)**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>// - **[72fad84e7](facebook/react@72fad84e7)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[c3fad5acf](facebook/react@c3fad5acf)**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>// - **[dd9120561](facebook/react@dd9120561)**: Kepp calling peformWork consistent (#13596) //<Heaven>// - **[42d12317a](facebook/react@42d12317a)**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>// - **[489614c4f](facebook/react@489614c4f)**: Updating dependencies for react-noop-renderer //<Brian Vaughn>// - **[351c9015c](facebook/react@351c9015c)**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>// - **[a210b5b44](facebook/react@a210b5b44)**: Revert "Do not bind topLevelType to dispatch" (#13674) //<Dan Abramov>// - **[1d8a75fef](facebook/react@1d8a75fef)**: remove flow typings from Schedule.js (#13662) //<Alexey Raspopov>// - **[d92114b98](facebook/react@d92114b98)**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (#13643) //<Nathan Hunzaker>// - **[0c9c591bf](facebook/react@0c9c591bf)**: Do not bind topLevelType to dispatch (#13618) //<Nathan Hunzaker>// - **[9f819a5ea](facebook/react@9f819a5ea)**: [schedule] Refactor Schedule, remove React-isms (#13582) //<Andrew Clark>// - **[9c961c0a2](facebook/react@9c961c0a2)**: Fix some iframe edge cases (#13650) //<Jérôme Steunou>// - **[8bc0bcabe](facebook/react@8bc0bcabe)**: Add UMD production+profiling entry points (#13642) //<Brian Vaughn>// - **[b488a5d9c](facebook/react@b488a5d9c)**: Fix test comment typo (#13568) //<Heaven>// - **[4bcee5621](facebook/react@4bcee5621)**: Rename "tracking" API to "tracing" (#13641) //<Brian Vaughn>// - **[72217d081](facebook/react@72217d081)**: Update bundle sizes for 16.5.1 release //<Dan Abramov>// - **[8b93a60c5](facebook/react@8b93a60c5)**: Updating package versions for release 16.5.1 //<Dan Abramov>// - **[ecbf7af40](facebook/react@ecbf7af40)**: Enhance dev warnings for forwardRef render function (#13627) (#13636) //<Andres Rojas>// - **[228240085](facebook/react@228240085)**: Delete TapEventPlugin (#13630) //<Dan Abramov>// - **[a079011f9](facebook/react@a079011f9)**: ð Stop syncing the value attribute on inputs (behind a feature flag) (#13526) //<Nathan Hunzaker>// - **[a7bd7c3c0](facebook/react@a7bd7c3c0)**: Allow reading default feature flags from bundle tests (#13629) //<Dan Abramov>// - **[d3bbfe09c](facebook/react@d3bbfe09c)**: Fix IE version in comment //<Dan Abramov>// - **[1b2646a40](facebook/react@1b2646a40)**: Fix warning without stack for ie9 (#13620) //<Aliaksandr Manzhula>// - **[e49f3ca08](facebook/react@e49f3ca08)**: honor displayName set on ForwardRef if available (#13615) //<Evan Jacobs>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010 Reviewed By: bvaughn Differential Revision: D10118547 fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071

Summary: This sync includes the following changes: - **[d83601080](facebook/react@d83601080)**: Wrap retrySuspendedRoot using SchedulerTracing (facebook#13776) //<Sophie Alpert>// - **[40a521aa7](facebook/react@40a521aa7)**: Terminology: Functional -> Function Component (facebook#13775) //<Dan Abramov>// - **[605ab10a4](facebook/react@605ab10a4)**: Add envify transform to scheduler package (facebook#13766) //<Michael Ridgway>// - **[acc7f404c](facebook/react@acc7f404c)**: Restart from root if promise pings before end of render phase (facebook#13774) //<Andrew Clark>// - **[cbc224028](facebook/react@cbc224028)**: fix - small misspelling (facebook#13768) //<Spencer Davies>// - **[4eabeef11](facebook/react@4eabeef11)**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>// - **[95a3e1c2e](facebook/react@95a3e1c2e)**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>// - **[96bcae9d5](facebook/react@96bcae9d5)**: Jest + test renderer helpers for concurrent mode (facebook#13751) //<Andrew Clark>// - **[5c783ee75](facebook/react@5c783ee75)**: Remove unreachable code (facebook#13762) //<Heaven>// - **[36c5d69ca](facebook/react@36c5d69ca)**: Always warn about legacy context within StrictMode tree (facebook#13760) //<Brian Vaughn>// - **[3e9a5de88](facebook/react@3e9a5de88)**: UMD react-cache build (facebook#13761) //<Maksim Markelov>// - **[8315a30b9](facebook/react@8315a30b9)**: --save is no longer needed (facebook#13756) //<Joe Cortopassi>// - **[ce96e2df4](facebook/react@ce96e2df4)**: Rename simple-cache-provider to react-cache (facebook#13755) //<Andrew Clark>// - **[c5212646f](facebook/react@c5212646f)**: Removed extra typeof checks for contextType.unstable_read (facebook#13736) //<Brian Vaughn>// - **[806eebdae](facebook/react@806eebdae)**: Enable getDerivedStateFromError (facebook#13746) //<Brian Vaughn>// - **[a0733fe13](facebook/react@a0733fe13)**: pure (facebook#13748) //<Andrew Clark>// - **[4d17c3f05](facebook/react@4d17c3f05)**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>// - **[469005d87](facebook/react@469005d87)**: Revise `AttributeType` React Native Flow Type (facebook#13737) //<Timothy Yung>// - **[0dc0ddc1e](facebook/react@0dc0ddc1e)**: Rename AsyncMode -> ConcurrentMode (facebook#13732) //<Dominic Gannaway>// - **[7601c3765](facebook/react@7601c3765)**: Ensure "addEventListener" exists on "window" for "scheduler" package (facebook#13731) //<Dominic Gannaway>// - **[d0c0ec98e](facebook/react@d0c0ec98e)**: Added a PureComponent contextType test (facebook#13729) //<Brian Vaughn>// - **[4b68a6498](facebook/react@4b68a6498)**: Support class component static contextType attribute (facebook#13728) //<Brian Vaughn>// - **[f305d2a48](facebook/react@f305d2a48)**: [scheduler] Priority levels, continuations, and wrapped callbacks (facebook#13720) //<Andrew Clark>// - **[970a34bae](facebook/react@970a34bae)**: Bump babel-eslint and remove flow supressions (facebook#13727) //<Brian Ng>// - **[13965b4d3](facebook/react@13965b4d3)**: Interaction tracking ref-counting bug fixes (WIP) (facebook#13590) //<Brian Vaughn>// - **[17e703cb9](facebook/react@17e703cb9)**: Restore global window.event after event dispatching (facebook#13688) (facebook#13697) //<Sergei Startsev>// - **[a775a767a](facebook/react@a775a767a)**: Remove redundant logic (facebook#13502) //<Heaven>// - **[e1a067dea](facebook/react@e1a067dea)**: Fix circular dependency in TracingSubscriptions (facebook#13689) //<Maksim Markelov>// - **[518812eeb](facebook/react@518812eeb)**: Clarify comment (facebook#13684) //<Heaven>// - **[eeb817785](facebook/react@eeb817785)**: Remove some old files from stats //<Dan>// - **[7ea3ca1d1](facebook/react@7ea3ca1d1)**: Rename schedule to scheduler (facebook#13683) //<Dan Abramov>// - **[bec2ddaf1](facebook/react@bec2ddaf1)**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>// - **[4269fafb0](facebook/react@4269fafb0)**: Updating package versions for release 16.5.2 //<Brian Vaughn>// - **[4380f9ba1](facebook/react@4380f9ba1)**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>// - **[72fad84e7](facebook/react@72fad84e7)**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>// - **[c3fad5acf](facebook/react@c3fad5acf)**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>// - **[dd9120561](facebook/react@dd9120561)**: Kepp calling peformWork consistent (facebook#13596) //<Heaven>// - **[42d12317a](facebook/react@42d12317a)**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>// - **[489614c4f](facebook/react@489614c4f)**: Updating dependencies for react-noop-renderer //<Brian Vaughn>// - **[351c9015c](facebook/react@351c9015c)**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>// - **[a210b5b44](facebook/react@a210b5b44)**: Revert "Do not bind topLevelType to dispatch" (facebook#13674) //<Dan Abramov>// - **[1d8a75fef](facebook/react@1d8a75fef)**: remove flow typings from Schedule.js (facebook#13662) //<Alexey Raspopov>// - **[d92114b98](facebook/react@d92114b98)**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (facebook#13643) //<Nathan Hunzaker>// - **[0c9c591bf](facebook/react@0c9c591bf)**: Do not bind topLevelType to dispatch (facebook#13618) //<Nathan Hunzaker>// - **[9f819a5ea](facebook/react@9f819a5ea)**: [schedule] Refactor Schedule, remove React-isms (facebook#13582) //<Andrew Clark>// - **[9c961c0a2](facebook/react@9c961c0a2)**: Fix some iframe edge cases (facebook#13650) //<Jérôme Steunou>// - **[8bc0bcabe](facebook/react@8bc0bcabe)**: Add UMD production+profiling entry points (facebook#13642) //<Brian Vaughn>// - **[b488a5d9c](facebook/react@b488a5d9c)**: Fix test comment typo (facebook#13568) //<Heaven>// - **[4bcee5621](facebook/react@4bcee5621)**: Rename "tracking" API to "tracing" (facebook#13641) //<Brian Vaughn>// - **[72217d081](facebook/react@72217d081)**: Update bundle sizes for 16.5.1 release //<Dan Abramov>// - **[8b93a60c5](facebook/react@8b93a60c5)**: Updating package versions for release 16.5.1 //<Dan Abramov>// - **[ecbf7af40](facebook/react@ecbf7af40)**: Enhance dev warnings for forwardRef render function (facebook#13627) (facebook#13636) //<Andres Rojas>// - **[228240085](facebook/react@228240085)**: Delete TapEventPlugin (facebook#13630) //<Dan Abramov>// - **[a079011f9](facebook/react@a079011f9)**: ð Stop syncing the value attribute on inputs (behind a feature flag) (facebook#13526) //<Nathan Hunzaker>// - **[a7bd7c3c0](facebook/react@a7bd7c3c0)**: Allow reading default feature flags from bundle tests (facebook#13629) //<Dan Abramov>// - **[d3bbfe09c](facebook/react@d3bbfe09c)**: Fix IE version in comment //<Dan Abramov>// - **[1b2646a40](facebook/react@1b2646a40)**: Fix warning without stack for ie9 (facebook#13620) //<Aliaksandr Manzhula>// - **[e49f3ca08](facebook/react@e49f3ca08)**: honor displayName set on ForwardRef if available (facebook#13615) //<Evan Jacobs>// Release Notes: [GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010 Reviewed By: bvaughn Differential Revision: D10118547 fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071

facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 21, 2017

jasonnoahchoi commented Apr 21, 2017

View reviewed changes

jasonnoahchoi force-pushed the chore/RCTLinkingManager branch 2 times, most recently from 34c244c to af368aa Compare April 22, 2017 17:03

javache requested changes Apr 27, 2017

View reviewed changes

javache requested changes May 2, 2017

View reviewed changes

jasonnoahchoi force-pushed the chore/RCTLinkingManager branch from a8bc3bd to d514b23 Compare May 2, 2017 18:48

facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 2, 2017

facebook-github-bot added Import Failed and removed Import Started This pull request has been imported. This does not imply the PR has been approved. labels May 3, 2017

javache approved these changes May 3, 2017

View reviewed changes

facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label May 3, 2017

javache added GH Review: needs-revision and removed GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. labels May 24, 2017

jasonnoahchoi added 5 commits May 25, 2017 11:05

Add application:openURL:options: for >= iOS9 target

c37cc49

Update comments in Linking.js

bad1474

Update example

6d55205

add postNotificationWithURL class func

529f966

code format, remove unnecessary semicolon

95a14b7

jasonnoahchoi added 5 commits May 25, 2017 11:27

lint spacing, change to c helper function

cc64558

create static func for linking notifications

a969fda

readd application:openURL:options: lost in merge conflict

33696d2

use new RCTLinkingManager method and fix spacing

98f7932

- update for true deprecation versions

remove remaining UIExplorer folder from rebase

eded86c

jasonnoahchoi force-pushed the chore/RCTLinkingManager branch from ff21360 to eded86c Compare May 25, 2017 16:02

facebook-github-bot added GH Review: review-needed and removed GH Review: needs-revision labels May 25, 2017

update comments lost in rebase

8191d48

facebook-github-bot added GH Review: accepted Import Started This pull request has been imported. This does not imply the PR has been approved. and removed GH Review: review-needed labels May 25, 2017

facebook-github-bot closed this in ff78a8d May 25, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add newly recommended method for RCTLinkingManager due to deprecation #13615

Add newly recommended method for RCTLinkingManager due to deprecation #13615

jasonnoahchoi commented Apr 21, 2017

jasonnoahchoi Apr 21, 2017

javache Apr 27, 2017

javache Apr 27, 2017

javache Apr 27, 2017

jasonnoahchoi May 1, 2017

javache May 2, 2017

javache May 2, 2017

jasonnoahchoi May 2, 2017

facebook-github-bot commented May 2, 2017

facebook-github-bot commented May 3, 2017

facebook-github-bot commented May 3, 2017

jasonnoahchoi commented May 10, 2017

javache commented May 10, 2017

javache commented May 24, 2017

jasonnoahchoi commented May 25, 2017

facebook-github-bot commented May 25, 2017

Add newly recommended method for RCTLinkingManager due to deprecation #13615

Add newly recommended method for RCTLinkingManager due to deprecation #13615

Conversation

jasonnoahchoi commented Apr 21, 2017

Motivation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

facebook-github-bot commented May 2, 2017

facebook-github-bot commented May 3, 2017

facebook-github-bot commented May 3, 2017

jasonnoahchoi commented May 10, 2017

javache commented May 10, 2017

javache commented May 24, 2017

jasonnoahchoi commented May 25, 2017

facebook-github-bot commented May 25, 2017