-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix examaple TabBarIOSExample bug; show click num when user click second & third tabbar #1522
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
This seems reasonable, but can you rebase and make sure tests are passing? |
@facebook-github-bot import |
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/894583160580151/int_phab to review. |
Can you rebase and re-record the snapshot tests to get the travis build to pass? |
@sahrens Can you rebase and re-record the snapshot tests to get the travis build to pass?--this is for @facebook-github-bot? if not be, how can I do? Thank you ~ |
The bot can't help here - you need to re-record for any change that will affect the snapshot tests. Follow the instructions in the docs here, update your PR, and make sure your Travis build passes and then we'll merge it in: |
…ond & third tabbar Summary: Closes facebook#1522 Github Author: lh_wang <[email protected]>
No description provided.