Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigator is deprecated #15230

Closed
wants to merge 1 commit into from
Closed

Navigator is deprecated #15230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Libraries/Components/StatusBar/StatusBar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ function createStackEntry(props: any): any {
* </View>
* ```
*
* ## Navigator is deprecated and has been removed from this package.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-trailing-spaces: Trailing spaces not allowed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at this point, i'm wondering if it's better to just update the example to be navigator agnostic.

@hramos

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Lets remove it altogether.

*
* It can now be installed and imported from react-native-deprecated-custom-components instead of react-native.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-trailing-spaces: Trailing spaces not allowed.

* Learn about alternative navigation solutions at http://facebook.github.io/react-native/docs/navigation.html
*
* ### Imperative API
*
* For cases where using a component is not ideal, there is also an imperative
Expand Down