Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extraneous check in deploy script #16837

Closed
wants to merge 2 commits into from
Closed

Remove extraneous check in deploy script #16837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1adfcb9
Remove extraneous check in deploy script
grabbou Nov 15, 2017
26bacc8
Make it run only on stable
grabbou Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,11 @@ aliases:
- /.*-stable/
- master

- &filter-only-stable
branches:
only:
- /.*-stable/

- &filter-ignore-gh-pages
branches:
ignore: gh-pages
Expand Down Expand Up @@ -476,6 +481,7 @@ jobs:
echo "Skipping code analysis."
fi

# Publishes new version to npm. This is "hold" type of job and has to be run manually
publish-npm:
<<: *defaults
docker:
Expand All @@ -486,15 +492,11 @@ jobs:
- run:
name: Publish React Native Package
command: |
if [ -z "$CIRCLE_PULL_REQUEST" ]; then
echo "//registry.npmjs.org/:_authToken=${CIRCLE_NPM_TOKEN}" > ~/.npmrc
git config --global user.email "[email protected]"
git config --global user.name "Website Deployment Script"
echo "machine github.com login reactjs-bot password $GITHUB_TOKEN" > ~/.netrc
node ./scripts/publish-npm.js
else
echo "Skipping publication."
fi
echo "//registry.npmjs.org/:_authToken=${CIRCLE_NPM_TOKEN}" > ~/.npmrc
git config --global user.email "[email protected]"
git config --global user.name "Website Deployment Script"
echo "machine github.com login reactjs-bot password $GITHUB_TOKEN" > ~/.netrc
node ./scripts/publish-npm.js

# Workflows enables us to run multiple jobs in parallel
workflows:
Expand Down Expand Up @@ -553,4 +555,4 @@ workflows:
- publish-npm:
requires:
- hold
filters: *filter-only-master-stable
filters: *filter-only-stable