Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Circle CI] Fix buck failures on master #17295

Closed
wants to merge 11 commits into from
Closed

[Circle CI] Fix buck failures on master #17295

wants to merge 11 commits into from

Conversation

hramos
Copy link
Contributor

@hramos hramos commented Dec 20, 2017

WIP.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2017
@hramos
Bump buck cache key version
3a749ab 
We did not update the cache key when buck was downgraded to 09, and this prevents us from testing with the 11 version
@pull-bot
Copy link

pull-bot commented Dec 20, 2017 •
edited
Loading

Fails
🚫

❔ This pull request needs a description.
Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

@facebook-github-bot label Needs more information

@facebook-github-bot label Needs more information

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

hramos and others added 9 commits December 20, 2017 14:38
@hramos
Move Android steps to aliases for clarity
e415ae7
@hramos
Remove branch name from cache keys
d92076b 
No need to use branch in cache keys when checksum is used, ensures cache hits in PRs, forks when checksummed files have not changed
@hramos
Update buck cache keys, separate out buck fetches
c336ac3 
We were previously omitting BUCK defs from the cache key, which could result in new deps not being pulled. Also, separate out buck fetches so it is clear which step is being performed in Circle UI
@hramos
Remove buck Android build cache
c48443d 
Upon further inspection, this cache is not contributing much.
Fix flow issues
@hramos
We can likely compile native libs before AVD is ready
e586765
@hramos
Do not use Node 8.x specific Stream.final
c8ca6d4 
This has been recently added to Node 8.x. Since it makes our tests to fail, I decided to
do a workaround that works for all the versions. Submitted by @grabbou.
@hramos
Cache entire android sdk folder
914b57b
@hramos
Remove comment that refers to deleted code
5faa17c
@hramos
Merge branch 'master' into buck-version
e8743f4
@pull-bot
Copy link

Fails
🚫

❔ This pull request needs a description.
Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.
⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

@facebook-github-bot label Needs more information

@facebook-github-bot label Needs more information

@facebook-github-bot label Needs more information

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the Import Started This pull request has been imported. This does not imply the PR has been approved. label Dec 22, 2017
facebook-github-bot
facebook-github-bot approved these changes Dec 22, 2017
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Contributor Author

hramos commented Dec 22, 2017

Not 100% there yet but landing to clear out some already-resolved errors on master.

@hramos hramos deleted the buck-version branch December 22, 2017 20:47
mathiasbynens pushed a commit to mathiasbynens/react-native that referenced this pull request Jan 13, 2018
@hramos @mathiasbynens
Fix buck failures on master
ff3dc7c 
Summary:
WIP.
Closes facebook#17295

Differential Revision: D6628523

Pulled By: hramos

fbshipit-source-id: ac2833e99de9e94340b8027469cc74a5b7379962
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
@hramos @facebook-github-bot
Fix buck failures on master
e81da37 
Summary:
WIP.
Closes facebook/react-native#17295

Differential Revision: D6628523

Pulled By: hramos

fbshipit-source-id: ac2833e99de9e94340b8027469cc74a5b7379962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot facebook-github-bot approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Import Started This pull request has been imported. This does not imply the PR has been approved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hramos @pull-bot @facebook-github-bot