-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue with on android with TextInput focus inside ScrollView #17892
Closed
Closed
Changes from 1 commit
Commits
Show all changes
467 commits
Select commit
Hold shift + click to select a range
6fc4163
Clean up FabricUIManagerViewHierarchyTest
ayc1 d52569c
check for GET and Head in send request
samsafay d7b5b2e
Allow Inspector to handle 2 renderers
fkgozali c129457
Typing ViewProp, ImageProp
elicwhite 321ba06
Type TextStyleProp
elicwhite 135637c
Merging tests for flattenStyle
elicwhite b58e377
Remove Unused Exports from StyleSheetTypes
elicwhite ec88489
Fixing bugs in link and unlink
rozele cade297
iOS Surface: properly reset some internal states when JS reloads
fkgozali ee26d9b
Make StyleSheet.create type private
elicwhite 49ffc9f
Rename StyleProp to DangerouslyImpreciseStyleProp
elicwhite a3c07c9
StyleObj -> DangerouslyImpreciseStyleProp
elicwhite 3c23645
Bump [email protected]
rafeca cf89a2c
Move __StyleProp to StyleSheet
elicwhite 23e0f86
Mark more ObjC methods called from RN as dynamic
tgrlnc 7bf3b20
iOS: create C++ <-> ObjC++ connector for FabricUIManager to do UI ope…
fkgozali a162dc8
Fix RefreshControl's dependency on AndroidSwipeRefreshLayout
ayc1 596bcb6
Initialize ReactChoreographer before creating the TimingModule
ayc1 8cdc7d3
Don't assume the SourceCode native module exists
ayc1 89757ed
Add eslint-plugin-react-native Yarn package and enable no-inline-styl…
SnowCoderAlex 5f497ca
Convert constant with build flags to function
d89517d
Remove usage of Internal StyleSheet type
elicwhite 852084a
Remove usage of Styles type
elicwhite 5b32358
Prettier
elicwhite 4895c64
Rename Style to DangerouslyImpreciseStyle
elicwhite f2ad77f
Update additional license headers
hramos ecd3d95
Ignore yarn.lock and package-lock.json in oss
hramos 49396aa
Fix typing of View refs
elicwhite dbdf43b
propTypes are optional for native components
elicwhite 214da52
AccessibilityLabel is optional
elicwhite 34f8e7f
`fabric/debug` module and `DebugStringConvertible` class
fkgozali 3c86701
`fabric/core` module and `Sealable` class
fkgozali 118521c
RN: Prettify Systrace
yungsters a8c4b63
RN: Delete Systrace for RelayClassic
yungsters 3e141cb
RN: Delete Systrace.swizzleJSON
yungsters 8803ab2
Fix race condition when there're two flags next to each other
alexeylang 20fcf47
Make fetchSegment native hook name consistent with __ prefix
fromcelticpark a7558d5
Clone ReactShadowNode when Yoga clones a YogaNode during layout
mdvacca e31781b
Add extra debug information to ReactShadowNodes objects
mdvacca c883d4e
Add "newProps" map into ReactShadowNode
mdvacca 2520c64
Fixing Assorted View Flow Types
elicwhite f1316ca
Making values optional in ViewPropTypes
elicwhite a48b4d5
Add Sonar support to Oculus Twilight Android
25b8ec8
Adding FlowFixMe when switching between Component and Ref
elicwhite 216c8ec
AndroidInfoModule now also returns Android ID
L33tcodex0r b6b80f6
Type VirtualizedList's ref
elicwhite 3e9a371
Mock ReactNative.NativeComponent native methods in jest
elicwhite c9d7562
Clear cache to resolve iOS, tvOS workflow
hramos 5035af8
Tightening types for View and VirtualizedList
elicwhite 274d6ce
Bump [email protected]
rafeca 1ff1e57
Add existing Android checks to Circle.
hramos 26734a8
Migrating View to be a Flow Typed ES6 class
elicwhite adabae2
Upgrade to Flow v0.67
nmote e057322
Fix Android Sanity Buck version check
hramos cd8128b
Move Text PropTypes to it's own file
elicwhite 3fd82d3
Fixing misuses of the Text type
elicwhite 01fffa2
RN: Remove DebugEnvironment from OSS
yungsters 450e562
export CompositeAnimation type
zjj010104 19dd9a2
Use -fdata-sections in mode/opt
amirlivneh 84affbd
Loosen Platform check to allow better code sharing for out-of-tree pl…
3002c4e
Fix tvOS react-native init release build (#18288)
douglowder 9c8c597
Don't truncate in the middle of an emoji
Vince0613 1dde989
Add support for springDamping in SpringInterpolator
axe-fb 0459e4f
Support Image resizeMode=repeat on Android
motiz88 ab92c00
Convert Text to ES6 Class
elicwhite 7a1c618
Change newly imported file to MIT license
hramos aa323d4
Use MIT license
hramos c136c54
Refactor RCTInputAccessoryView view hierarchy and names
ca898f4
Add docs for Swift usage to RCTBridgeModule.h
ejmartin504 41acb0a
Fix clang-6 compile error (virtual destructor)
9737774
Fix crash in Sapienz bot for Interpolator type
axe-fb db061ea
Don't wrap ListEmptyComponent in an extra view
janicduplessis 8466db0
Revert #17927
af4a363
Remove the usage of YGUndefined in the default values of Border in YG…
priteshrnandgaonkar 9f7e703
Changed the return type of YGResolveValue
priteshrnandgaonkar 5b3d595
Change the type of flex to YGFloatOptional
priteshrnandgaonkar 3274e9f
Change the type of flexGrow to YGFloatOptional
priteshrnandgaonkar e3af150
Change the type of flexShrink to YGFloatOptional
priteshrnandgaonkar f3ef8f8
Remove the use of YGUndefined for flex-basis
priteshrnandgaonkar 321b107
Expose layout diffing flag to java
priteshrnandgaonkar a01ae8b
Bump [email protected]
rafeca 4f8328b
React sync for revisions ab4280b...ad9544f
hramos bec97dc
Expose native show message method in header
3a2bdf5
Move Fabric JSC bindings to oss
ayc1 7ce943e
Adds _lineHeight = NAN; to RCTTextAttributes
aparedes 6765699
Move Image PropTypes to a new file
elicwhite 8bac869
Create Flow Props for Image
elicwhite 28c9c68
Adding documentation to new StyleSheet Flow Types
elicwhite c595509
Add number-pad keyboardType
khaeransori 304db5c
Add MIT license to Fabric
ayc1 d678058
Add Fabric integration test
ayc1 22004db
React sync for revisions ad9544f...ced176e
6b1dc71
Refactor resolvePlugins out to prepare for babel 7
040642d
Fix setter and getter of margin, position, border and padding
priteshrnandgaonkar da2d410
Fix getters and setters if min and max Dimension
priteshrnandgaonkar c989ea8
Extract NativeExtensionsProvider definition
8e85bf8
Gatekeeper for Native Extensions
139d554
Replace js Dimensions with shadow view in InputAccessoryViewExample
ce92b85
Fixed a typo and added a test case
priteshrnandgaonkar 9102ff9
Moved YGFloatOptional from C struct to C++ struct
priteshrnandgaonkar f376fe3
Remove @xplat cell syntax in open source
hramos b02b167
Bump [email protected]
rafeca dbd4759
Local cli/android/normalize project name
Titozzz 076b1ce
Prevent show a hidden status bar when opening modals, fix #7474
t4deu 6f6084d
Explicitly set path to yarn
hramos 6426735
Simplify templates
hramos 353c070
Add a way to dismiss PopupMenu elements
miguelsm c2fd54f
Enable obfuscation in ProGuard rules by default
fractalwrench 6f588b3
Fix Android job
hramos 541485c
Add inverted prop in SectionListExample
kyo504 1c53471
iOS OSS: fixed RNTester - missing RCTInputAccessoryShadowView.* in .x…
fkgozali d16772a
Sealable: fixed semantic; atomic type for the flag variable
shergin c623455
Abstract classes for ShadowNode and Props
shergin 608d1fb
`fabric/graphics` module: all about graphics
shergin 840638c
Introducing `ComponentDescriptor`
shergin 811d5bf
Introducing LayoutableShadowNode
shergin 6b0960c
Introducing `ConcreteShadowNode`
shergin 965e60b
`fabric/view` module
shergin c2ad59a
`fabric/uimanager` module
shergin 4cda0df
Switching to the new FabricUIManager and all new shadow tree infra
shergin 378da73
DebugStringConvertibleOptions: Formating
shergin 263d04d
Added nestedScrollEnabled prop to scroll view for android
tuncaulubilge f42b589
iOS C++: Add ICxxExceptionManager to access RCTExceptionsManager nati…
fkgozali 53a0470
iOS JSC: Use ICxxExceptionManager to report exception
fkgozali def789c
Wrong height when TextInput has an empty string
reyalpsirc c732429
Make access to SourceCode Native Extension lazy
15bc6d1
Added console warning to InputAccessoryView
12c208c
Create a new instrumentation test that does not enforce rendering a s…
ayc1 9d45de6
Properly tear down the reachabilityRef in RCTNetInfo
41db09d
Remove @xplat cell syntax in open source, part 2
hramos ff70ecf
Fixed <TextInput> bug with autocapitalization
12535ae
Fix clang-6 strictness surrounding virtual destructors
75a7359
RCTObjcExecutor: fix initializer-list initialization order build warn…
fbartho aaaa946
Fabric: Equality operators for geometry types
shergin a5a3456
Fabric: Proper return value of `LayoutableShadowNode::setLayoutMetric…
shergin ff288b7
Fabric: Complete implementation of `layoutMetricsFromYogaNode`
shergin 39383d1
Fabric: Improved YogaLayoutableShadowNode printing
shergin b808bfd
Fabric: Introducting `ShadowNode.sourceNode`, the node used in copy-c…
shergin e2462e9
iOS: set the default measure size correctly for RCTSurfaceHostingView
fkgozali 0930fef
Disable YogaNode cloning in Android
mdvacca b43afcd
Change cloning mechanism for mutableCopyWithNewChildren method
mdvacca 3f84a0a
Extend ReactShadowNode in order to have a reference to the ReactShado…
mdvacca 7d3de10
Implement Fabric Reconciler
mdvacca cc3d45d
Add logging to debug Fabric diffing algorithm
mdvacca 5347ecf
Fix removal of ReactShadowNode
mdvacca 0d924dd
Upgrade to Flow v0.68.0
samwgoldman 785c8f7
Use native as the source of truth to decide if a test should use Fabric
ayc1 c49afb1
Add debug logs to FabricUIManager
ayc1 f136ae1
Add test for FabricText
ayc1 af42829
Fix TextRenderingTestCase
ayc1 aabd5d1
Use map instead of array
cwdick fa7c322
Depend on local version of babel-plugin-react-transform
f6bcd73
feat: Remove platform check in requireNativeComponent to support addi…
jhampton ad6938c
Revert D7319513: Depend on local version of babel-plugin-react-transform
6f339b6
Deprecate postProcessModules config param
rafeca 15f0a7b
Add getRunModuleStatement config param to configure the require() sta…
rafeca ddfcaf9
Drop fb{android|objc} prefixed keys for oss builds
ea92f47
While linking plugin ask for params only once
38fe8c2
moved ReactFabricInternals outside of shims
fkgozali 3b36a6b
React sync for revisions ced176e...9d484ed
hramos f68e041
Move TypeForStyleKey from StyleSheetTypes to StyleSheet
elicwhite a0388f4
Move ViewStyle, TextStyle, ImageStyle from StyleSheetTypes to StyleSheet
elicwhite a3f1ca8
Bump [email protected]
rafeca 657c1a4
Add more debug logs to FabricReconciler
ayc1 b961ac3
Depend on local version of babel-plugin-react-transform
0594a10
Removed unnecessary `intrinsicContentSize` implementation from `RCTSu…
shergin 909861f
Fixed race condition in RCTUIManager's mounting process
shergin c194c18
Fixed performance regression in `ShadowView`s layout process
shergin d50cefb
Moving remaining Style types from StyleSheetTypes to StyleSheet
elicwhite cf036db
Updates Yoga to handle being in a Xcode framework project
orta c0d27de
Fix removal of virtual nodes in FabricReconciler
ayc1 0b085a8
Pass-by-reference in YGNode::setStyle() ::setChildren() ::setLayout()
ed0ba1b
Pass some constructor argumetns by const-reference
cb3103c
Mark more member functions as const
f015900
fixed debug string formatting for structure
fkgozali 6ae38fe
Added sample iOS unit test setup for fabric/debug target
fkgozali 96daf67
Fix OSS Android test failure
47910f0
Set measure function after YogaNode has been copied
ayc1 8e065ba
Update fresco to v1.8.1
AndrewJack ff1444e
Add fresco proguard rules
AndrewJack 10c95a2
fixed contacts for the test target
fkgozali 15fa225
fix ReadableNativeMap.toHashMap() for nested maps and arrays
esamelson cf642c9
Mark global variable as extern "C"
smeenai 0376baf
Revert D7343566: [RN] Fixed race condition in RCTUIManager's mounting…
shergin 046d4ce
Assert root node isn't null in createView
ayc1 cbb7c7c
Pass fabric flag from native to JS
ayc1 dd479a9
Pass invertStickyHeaders to ScrollView
dannycochran 8c0070c
iOS: added fabric/core primitives tests
fkgozali e254474
iOS: added fabric/core ShadowNode tests
fkgozali 408a5f2
iOS: added fabric/core ComponentDescriptor tests
fkgozali 1acef45
iOS: added placeholder test setup for fabric graphics/uimanager/view …
fkgozali 228f5c8
use correct delegate queue in RCTRSWebSocket
jhgg 2cc75f7
Add YGNodeSetChildren(), YGNodeTraversePreOrder()
8b9b3f6
Correct AnimatedValueXY URL
gusgard 85e33aa
Prevents android crash due to unsupported ellipsize mode
t4deu 226bff3
Android: include error types in getCurrentPosition error
dulmandakh ca20fcd
Use afterEvaluate to make gradle bundle task work with configureondemand
janicduplessis 53782ea
Fabric: Source shadow node is now stored as a weak pointer
shergin 1bb6db3
Fabric: Removed unused copy constructor YogaLayoutableShadowNode()
shergin 8f9212b
Fabric: Fixed lost YogaNode's context in YogaLayoutableShadowNode
shergin ee0cc6b
Fabric: Implementing cloneAndReplaceChild() for ViewShadowNode
shergin 5642514
Fabric: Detailed looging in FabricUIManager
shergin 53dfbcc
Fabric: Fixed bug in node management in FabricUIManager
shergin 6f17e3b
Fabric: Introducing `TreeMutationInstruction`
shergin cb7a7f3
Fabric: Deleted virtual default destructor from Props
shergin 99e9c6e
Fabric: Collecting and printing ShadowNode's revision/generation
shergin 2ff8b70
Replace android_library with fb_android_library.
ttsugriy de1040f
Cache apt dependencies in test_android
hramos f5207ba
Fix blob response parsing for empty body on iOS
janicduplessis 0150a0c
Add nativeLoggingHook to JSIExecutor
45abbf3
Support multiple Fabric ReactRootView running at the same time
mdvacca 56971bb
RN: Fix rounded Image Background (Android)
himabindugadupudi 2ebd55f
Upgrade Jest to 23.0.0-alpha.4
15b25d8
Cache C++ downloads
hramos e3941a1
Native Animated - Support border radius
janicduplessis 979c01e
Build yoga in OSS
hramos f96d7ae
Bridged FBPullToRefresh to JS
fd4bc72
Add custom RefreshControl support to VirtualizedList
9c80506
Refactor RootShadowNodeRegistry to make it ThreadSafe
mdvacca bd134ce
Increase timeouts to 15, 10
88ba7eb
Fix "function statements" in strict mode builds
7cbb222
Remove class-loading experiment for View Managers.
b531612
Collect unit test results in test_android job
hramos e88f128
Refactor ReactShadowNode.SetRootNode() -> ReactShadowNode.setRootTag()
mdvacca ff2260b
Add `JByteBuffer::rewind()`
davidaurelio f3ef227
Upgrade to Flow v0.69.0
gabelevi 24b5721
Fix `ByteBuffer.h`
davidaurelio 6be7b39
Update okio
davidaurelio 9bdc310
Update Android Docker images
hramos ee0c69d
Keep nativeIDs immutable in ReactFindViewUtil
axe-fb 1020ac9
OSS: add gradle wrapper helper to prepare offline gradle caches
fkgozali 550339c
Add `JReadableByteChannel`
davidaurelio 1f27098
Fabric: Proper Yoga node dirting in YogaLayoutableShadowNode
shergin 4906f8d
Add an implementation of Animated.subtract
avendiart d58ba82
Avoid app crashing when a StackOverflowError is thrown when rendering…
mdvacca aff5a75
Refactor cloning of YogaNode
mdvacca 29ff30c
Rename YogaNode.parent -> YogaNode.owner
mdvacca 5be4ff0
Extend Yoga to be able clone Yoga Node with new children
mdvacca 8a99241
Re-enable Yoga cloning in React Shadow Node
mdvacca d4fb87b
Add iOS 10 textContentType for TextInput
cbrevik 201e74f
Fix tvOS build breakage in RCTAnimation Xcode project
douglowder 976712a
Replace RN exception handling override with new version
pakoito e5a4d59
Remove the usage of YGUndefined for kYGValueAuto and fix setter and g…
priteshrnandgaonkar bcd12f1
Change the type of aspect Ratio to YGFloatOptional
priteshrnandgaonkar 63c073d
Move equaltiy function from utils to an operator on YGFloatOptional
priteshrnandgaonkar f84f4fd
Changed the return type of YGResolveValueMargin to YGFloatOptional
priteshrnandgaonkar 7469458
fix(RCTImageLoader): Adds `requiresMainQueueSetup` to fix v0.52
iRoachie cdfc346
Fix wrong root path in RNTester gradle config
sunnylqm 591fab1
Update ScrollView.js
mistenkt 7e90226
Merge branch 'master' of github.com:mistenkt/react-native
mistenkt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PeteTheHeat, shouldn't this warning be constrained to only occur on Android?