Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onLayout prop for TextInput on Android #18040

Closed
wants to merge 1 commit into from
Closed

Fix onLayout prop for TextInput on Android #18040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Components/TextInput/TextInput.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ const TextInput = createReactClass({

return (
<TouchableWithoutFeedback
onLayout={this._onLayout}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we do this.props.onLayout to maintain equality?

Copy link
Contributor Author

@rozele rozele Feb 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chirag04 - this.props is copied into a local variable:
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L836

This is exactly how it's done for iOS:
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L771
https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L822

onLayout={props.onLayout}
onPress={this._onPress}
accessible={this.props.accessible}
accessibilityLabel={this.props.accessibilityLabel}
Expand Down