-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLI]Add iOS Validate Environment Script #19750
Closed
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
#!/bin/bash | ||
|
||
# This script validates that iOS is set up correctly for the | ||
# testing environment. | ||
# | ||
# In particular, it checks that the minimum required Xcode version is installed. | ||
# It also checks that the correct Node version is installed. Node 10 is not fully | ||
# supported at the time and Node 6 is no longer supported. | ||
|
||
# Function used to compare dot seperated version numbers | ||
function version_gt() { test "$(printf '%s\n' "$@" | sort -V | head -n 1)" != "$1"; } | ||
|
||
# Check that node is installed. | ||
if [ -z "$(which node)" ]; then | ||
echo "You need to install nodejs." | ||
echo "Note: Node 10 is not fully supported at the time and Node 6 is no longer supported." | ||
echo "See https://nodejs.org/en/download/ for instructions." | ||
exit 1 | ||
fi | ||
|
||
# Check that the correct version of node is installed | ||
NODE_VERSION="$(command node --version | sed 's/[-/a-zA-Z]//g' |sed 's/.\{2\}$//')" | ||
|
||
if (( $(echo "${NODE_VERSION} <= 6.0" | bc -l) )); then | ||
echo "Node ${NODE_VERSION} detected. This version of Node is not supported." | ||
echo "Note: Node 10 is not fully supported at the time and Node 6 is no longer supported." | ||
echo "See https://nodejs.org/en/download/ for instructions." | ||
exit 1 | ||
fi | ||
|
||
if (( $(echo "${NODE_VERSION} == 10.0" | bc -l) )); then | ||
echo "Node ${NODE_VERSION} detected. This version of Node is not supported." | ||
echo "Note: Node 10 is not fully supported at the time and Node 6 is no longer supported." | ||
echo "See https://nodejs.org/en/download/ for instructions." | ||
exit 1 | ||
fi | ||
|
||
# Check that Xcode is installed. | ||
if [ -z "$(which xcodebuild)" ]; then | ||
echo "You need to install nodejs." | ||
echo "Note: Node 10 is not fully supported at the time, Node 6 is no longer supported" | ||
echo "See https://nodejs.org/en/download/ for instructions." | ||
exit 1 | ||
fi | ||
|
||
MIN_XCODE_VERSION=8.0 | ||
# Check that the correct version of Xcode is installed | ||
XCODE_VERSION="$(command xcodebuild -version | sed '$ d' | sed 's/[-/a-zA-Z]//g')" | ||
if (version_gt $MIN_XCODE_VERSION $XCODE_VERSION) && [ "$XCODE_VERSION" != "$MIN_XCODE_VERSION" ]; then | ||
echo "Xcode ${XCODE_VERSION} detected. Please upgrade to a later version using the AppStore." | ||
echo "Older versions of Xcode may cause cryptic build errors." | ||
exit 1 | ||
fi |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tihnk this is the wrong error message for
xcodebuild