Android: fix cookies lost on Android 5.0 and above #19770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Can we please have this merged if it fixes the issue? |
This comment has been minimized.
This comment has been minimized.
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Can we merge this now? |
ghost
mentioned this pull request
3 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hramos
reviewed
Aug 6, 2018
| @@ -129,6 +129,7 @@ public void run() { | |||
| for (String cookie : cookies) { | |||
| addCookieAsync(url, cookie); | |||
| } | |||
| getCookieManager().flush(); | |||
There was a problem hiding this comment.
It looks like the cookies are added asynchronously. Can we guarantee cookies have finished being added before they are flushed / written to permanent storage?
There was a problem hiding this comment.
Yes. Cookies have been obtained before being flushed to disk.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 28, 2018
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
chenwenyu merged commit ea53727 into |
grabbou
pushed a commit
that referenced
this pull request
Oct 2, 2018
Summary: This fixes cookie missing bug on Android 5.0 and above. On Android 5.0 and above, after the app successfully obtains the cookie, you kills the App within 30 seconds and restarts the App. It accesses the interface that needs to carry the cookie and finds that the cookie does not exist. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. [ANDROID] [BUGFIX] [Cookie] - Fix cookies lost on Android 5.0 and above Pull Request resolved: #19770 Differential Revision: D10114102 Pulled By: hramos fbshipit-source-id: 5b4766f02f70541fd46ac5db36f1179fe386ac7a
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This fixes cookie missing bug on Android 5.0 and above. On Android 5.0 and above, after the app successfully obtains the cookie, you kills the App within 30 seconds and restarts the App. It accesses the interface that needs to carry the cookie and finds that the cookie does not exist. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. [ANDROID] [BUGFIX] [Cookie] - Fix cookies lost on Android 5.0 and above Pull Request resolved: facebook#19770 Differential Revision: D10114102 Pulled By: hramos fbshipit-source-id: 5b4766f02f70541fd46ac5db36f1179fe386ac7a
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Oct 28, 2020
Summary: This fixes cookie missing bug on Android 5.0 and above. On Android 5.0 and above, after the app successfully obtains the cookie, you kills the App within 30 seconds and restarts the App. It accesses the interface that needs to carry the cookie and finds that the cookie does not exist. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. [ANDROID] [BUGFIX] [Cookie] - Fix cookies lost on Android 5.0 and above Pull Request resolved: facebook#19770 Differential Revision: D10114102 Pulled By: hramos fbshipit-source-id: 5b4766f02f70541fd46ac5db36f1179fe386ac7a
KusStar
pushed a commit
to KusStar/react-native
that referenced
this pull request
Oct 30, 2020
Summary: This fixes cookie missing bug on Android 5.0 and above. On Android 5.0 and above, after the app successfully obtains the cookie, you kills the App within 30 seconds and restarts the App. It accesses the interface that needs to carry the cookie and finds that the cookie does not exist. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior. [ANDROID] [BUGFIX] [Cookie] - Fix cookies lost on Android 5.0 and above Pull Request resolved: facebook#19770 Differential Revision: D10114102 Pulled By: hramos fbshipit-source-id: 5b4766f02f70541fd46ac5db36f1179fe386ac7a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cookie missing bug on Android 5.0 and above.
On Android 5.0 and above, after the app successfully obtains the cookie, you kills the App within 30 seconds and restarts the App. It accesses the interface that needs to carry the cookie and finds that the cookie does not exist.
Test Plan
Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior.
Related PRs
Updated tests for the addCookies function to include test cases specifying Android version, and tested on the command line in my app to make sure it has the expected behavior.
Release Notes
[ANDROID] [BUGFIX] [Cookie] - Fix cookies lost on Android 5.0 and above