Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gradle to 4.4 #19899

Closed
wants to merge 1 commit into from
Closed

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Jun 26, 2018

Bump gradle to 4.4, version used by android studio 3.x and gradle plugin 3.x. This will help make migration easier and smoother.

CI: https://circleci.com/gh/dulmandakh/react-native/591

FYI: I found that gradle 4.8 works fine with gradle plugin 2.3, but gradle plugin 3.x displays warnings and asks to disable on demand configuration.

Test Plan:

Builds and runs as usual

Release Notes:

[ANDROID] [ENHANCEMENT] [GRADLE] - bump to 4.4

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 26, 2018
@react-native-bot react-native-bot added ✅Test Plan Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature. labels Jun 26, 2018
@dulmandakh
Copy link
Contributor Author

Please review @hramos @mdvacca

@dulmandakh dulmandakh mentioned this pull request Jun 28, 2018
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@hramos
Copy link
Contributor

hramos commented Jun 29, 2018

@dulmandakh this won't be merged just yet, as I need to update our internal Gradle tests to use 4.8 as well. I've imported your changes and I'll land them alongside my internal test changes. It's on my queue, however, so it should not be long.

@dulmandakh
Copy link
Contributor Author

dulmandakh commented Jun 29, 2018 via email

@slorber
Copy link
Contributor

slorber commented Jul 3, 2018

@hramos in the meantime, is there any documentation on how to dev RN apps as of today? Because latest Android Studio version requires Gradle 4.4 as minimum version.

Just wondering what is the best option as of today to solve my problems. Maybe downgrading to 2.x AS is the solution: https://developer.android.com/studio/archive

@hramos
Copy link
Contributor

hramos commented Jul 3, 2018

@slorber you can update the gradle-wrapper.properties file in your own project even if this PR is not yet merged. It should not be long, though this won't make it into a release until 0.57 most likely.

@react-native-bot
Copy link
Collaborator

This pull request was closed by @dulmandakh in 33d20da.

Once this commit is added to a release, you will see the corresponding version tag below the description at 33d20da. If the commit has a single master tag, it is not yet part of a release.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 4, 2018
@react-native-bot react-native-bot added the Merged This PR has been merged. label Jul 4, 2018
@dulmandakh dulmandakh deleted the bump-gradle-44 branch August 22, 2018 03:31
grabbou pushed a commit to react-native-community/cli that referenced this pull request Sep 26, 2018
Summary:
Bump gradle to 4.4, version used by android studio 3.x and gradle plugin 3.x. This will help make migration easier and smoother.

CI: https://circleci.com/gh/dulmandakh/react-native/591

FYI: I found that gradle 4.8 works fine with gradle plugin 2.3, but gradle plugin 3.x displays warnings and asks to disable on demand configuration.
Closes facebook/react-native#19899

Reviewed By: fkgozali

Differential Revision: D8697929

Pulled By: hramos

fbshipit-source-id: 21eb625ee1e4a1fa02aa22de4c36a07269ca467b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: Android Android applications. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants