-
Notifications
You must be signed in to change notification settings - Fork 24.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump gradle to 4.4 #19899
bump gradle to 4.4 #19899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
@dulmandakh this won't be merged just yet, as I need to update our internal Gradle tests to use 4.8 as well. I've imported your changes and I'll land them alongside my internal test changes. It's on my queue, however, so it should not be long. |
@hramos it's 4.4. Version 4.8 will cause problems if used with Gradle
plugin 3.1, maybe 3.0.
|
@hramos in the meantime, is there any documentation on how to dev RN apps as of today? Because latest Android Studio version requires Gradle 4.4 as minimum version. Just wondering what is the best option as of today to solve my problems. Maybe downgrading to 2.x AS is the solution: https://developer.android.com/studio/archive |
@slorber you can update the |
This pull request was closed by @dulmandakh in 33d20da. Once this commit is added to a release, you will see the corresponding version tag below the description at 33d20da. If the commit has a single |
Summary: Bump gradle to 4.4, version used by android studio 3.x and gradle plugin 3.x. This will help make migration easier and smoother. CI: https://circleci.com/gh/dulmandakh/react-native/591 FYI: I found that gradle 4.8 works fine with gradle plugin 2.3, but gradle plugin 3.x displays warnings and asks to disable on demand configuration. Closes facebook/react-native#19899 Reviewed By: fkgozali Differential Revision: D8697929 Pulled By: hramos fbshipit-source-id: 21eb625ee1e4a1fa02aa22de4c36a07269ca467b
Bump gradle to 4.4, version used by android studio 3.x and gradle plugin 3.x. This will help make migration easier and smoother.
CI: https://circleci.com/gh/dulmandakh/react-native/591
FYI: I found that gradle 4.8 works fine with gradle plugin 2.3, but gradle plugin 3.x displays warnings and asks to disable on demand configuration.
Test Plan:
Builds and runs as usual
Release Notes:
[ANDROID] [ENHANCEMENT] [GRADLE] - bump to 4.4