Fix local-cli assetRegistryPath and middlewares

[janicduplessis]

This fixes some regressions with local-cli introduced in c4a66a8. Fixes #20008.

• We didn't pass assetRegistryPath which caused the following error when loading the bundle:

error: bundling failed: Error: Unable to resolve module `missing-asset-registry-path` from `/Users/janic/Developer/react-native/RNTester/js/[email protected]`: Module `missing-asset-registry-path` does not exist in the Haste module map

• The middlewares were not added to the metro server. This causes some packager server features to fail. The one I noticed is that the /status endpoint didn't exist anymore which causes CI to fail and also Android to not load the bundle from the packager initially. The remote debugging feature was also broken.

Test Plan:

• Run RNTester and make sure the app loads properly.
• Test the /status endpoint to make sure middlewares are added.
• Test remote debugging and make sure it works as expected.

Release Notes:

Marking this as internal since the regression hasn't made it to a release.

[INTERNAL] [BUGFIX] [runServer.js] - Fix local-cli assetRegistryPath and middlewares

[janicduplessis]

CI is back to green with this :)

[janicduplessis]

I found more issues with remote debugging because we don't attach the websocket proxy, looking into a fix.

[janicduplessis]

Looks like hmr is not working also 🙃

[janicduplessis]

A lot of config keys were on the wrong object, hmr now works.

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[hramos]

Error ---------- local-cli/server/runServer.js:59:48
Cannot call `Metro.runServer` with object literal bound to the first parameter because property `watch` is missing in `RunServerOptions` [1] but exists in object literal [2].

                                                     v
  59|   const serverInstance = await Metro.runServer({
  60|     config: {
  61|       ...config,
    :
  77|     watch: !args.nonPersistent,
  78|   });
      --^

References:
  metro/packages/metro/src/index.js:201:4
  201| }: RunServerOptions) => {
          ^^^^^^^^^^^^^^^^ [1]
                                                     v
  59|   const serverInstance = await Metro.runServer({
  60|     config: {
  61|       ...config,
    :
  77|     watch: !args.nonPersistent,
  78|   });
      --^ [2]

[hramos]

A Flow error is preventing the internal diff from landing.

[janicduplessis]

@hramos Oh right, we ignore metro flow types in OSS so I it must be why I missed it. Working on a fix.

[janicduplessis]

The watch key isn't used by metro (it overrides it to true always), not sure what the nonPersistent is for but breaking this is better than the current state of things :)

[janicduplessis]

@hramos Should be good to land now

[facebook-github-bot]

@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

This pull request was closed by @janicduplessis in f05943d.

Once this commit is added to a release, you will see the corresponding version tag below the description at f05943d. If the commit has a single master tag, it is not yet part of a release.