[Packager] Include Content-Type headers with bundle and source maps #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sahrens could you merge this in with the next sync or so? It's a fairly small and self-contained diff. |
facebook-github-bot
added
the
CLA Signed
|
Is this a regression/did something break? Also, looks like you might need to update Server-test.js since it failed on travis? |
|
Nothing broke; I would like the content type headers though. Will look into the tests. |
ide
force-pushed
the
packager-content-type
branch
from
c7dbb50 to
d603392
Compare
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
The packager did not send back the Content-Type headers. Adding these. Test Plan: Run UIExplorer in JSC to ensure the bundle loads. Run it in the Chrome debugger to ensure that source maps load.
|
Tests are now green -- needed to stub out a function in the test file. |
ptmt
pushed a commit
to ptmt/react-native
that referenced
this pull request
Jul 28, 2015
Summary: The packager did not send back the Content-Type headers. Adding these. Closes facebook#2029 Github Author: James Ide <[email protected]>
cpojer
pushed a commit
to facebook/metro
that referenced
this pull request
Jan 26, 2017
Summary: The packager did not send back the Content-Type headers. Adding these. Closes facebook/react-native#2029 Github Author: James Ide <[email protected]>
FalseLobster
pushed a commit
to FalseLobster/react-native
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The packager did not send back the Content-Type headers. Adding these.
Test Plan: Run UIExplorer in JSC to ensure the bundle loads. Run it in the Chrome debugger to ensure that source maps load.