Switch babel preset to metro-react-native-babel-preset #20653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
(not really sure why CI is failing though) |
janicduplessis
approved these changes
Aug 13, 2018
|
Thanks! @facebook-github-bot shipit |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Aug 13, 2018
There was a problem hiding this comment.
janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was closed by @LinusU in 35bd17f. Once this commit is added to a release, you will see the corresponding version tag below the description at 35bd17f. If the commit has a single |
kelset
pushed a commit
that referenced
this pull request
Aug 13, 2018
grabbou
pushed a commit
to react-native-community/cli
that referenced
this pull request
Sep 26, 2018
Summary: Fixes #20567 Pull Request resolved: facebook/react-native#20653 Differential Revision: D9296819 Pulled By: hramos fbshipit-source-id: 88953afb9778e3c8cde5576b068888fd882c2220
hramos
removed
Import Started
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20567, #20327
Test Plan:
Test to create a bare-bones project and run it on a device.
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [BUGFIX] [Babel] - Switch templated babel preset from
babel-preset-react-nativetometro-react-native-babel-preset