[FlowCleanup] Replace DeprecatedViewPropTypes.style for ViewStyleProp on IntegrationTestHarnessTest and InputAccessoryView #21397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
🔶Components
Missing Changelog
ronal2do
changed the title
RSNara
reviewed
Sep 28, 2018
| }; | ||
| type Props = $ReadOnly<{| | ||
| shouldThrow?: boolean, | ||
| waitOneFrame?: boolean, |
There was a problem hiding this comment.
type Props = $ReadOnly<{|
shouldThrow?: ?boolean,
waitOneFrame?: ?boolean,
|}>| +children: React.Node, | ||
| /** | ||
| * An ID which is used to associate this `InputAccessoryView` to | ||
| * specified TextInput(s). | ||
| */ | ||
| nativeID?: string, | ||
| style?: DeprecatedViewPropTypes.style, | ||
| style?: ViewStyleProp, |
There was a problem hiding this comment.
type Props = $ReadOnly<{|
+children: React.Node,
nativeID?: ?string,
style?: ?ViewStyleProp,
backgroundColor?: ?DeprecatedColorPropType
...
RSNara
requested changes
Sep 28, 2018
|
Fixed, thanks for you feedback |
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
hramos
changed the title
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
…nTestHarnessTest and InputAccessoryView (facebook#21397) Summary: related facebook#21342 Pull Request resolved: facebook#21397 Reviewed By: TheSavior Differential Revision: D10119623 Pulled By: RSNara fbshipit-source-id: 16bdb3d5bf90c24b597bbc12fc416a50a0aa2bb1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #21342
Test Plan:
Release Notes:
[GENERAL] [ENHANCEMENT] [InputAccessoryView.js] Replace DeprecatedViewPropTypes.style for ViewStyleProp
[GENERAL] [ENHANCEMENT] [IntegrationTestHarnessTest.js] Replace PropTypes