[SubscribableMixin] Remove SubscribableMixin from SizeFlexibilityUpdateTest #21580
Conversation
facebook-github-bot
added
the
CLA Signed
RSNara
changed the title
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
|
||
| UNSAFE_componentWillMount: function() { | ||
| this.addListenerOn( | ||
| RCTNativeAppEventEmitter, | ||
| this._subscription = RCTNativeAppEventEmitter.addListenerOn( |
There was a problem hiding this comment.
This should have actually been:
this._subscription = RCTNativeAppEventEmitter.addListener(There's no method called RCTNativeAppEventEmitter.addListenerOn. But it's no big deal, I patched it internally. 🙂
There was a problem hiding this comment.
I wasn't able to test it 😅. Thanks
facebook-github-bot
added
the
Import Started
|
Updated |
facebook-github-bot
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
There was a problem hiding this comment.
RSNara has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Related to facebook#21485 Remove SubscribableMixin from SizeFlexibilityUpdateTest - All flow tests succeed. - yarn run test-android-instrumentation && CI integration tests [GENERAL] [ENHANCEMENT] [SizeFlexibilityUpdateTest.js] - rm SubscribableMixin Pull Request resolved: facebook#21580 Reviewed By: TheSavior Differential Revision: D10276267 Pulled By: RSNara fbshipit-source-id: fc89b43099c788cba560c9aaf0819cd5cfab38c3
Related to #21485
Remove SubscribableMixin from SizeFlexibilityUpdateTest
Test Plan:
yarn run test-android-instrumentation&& CI integration testsRelease Notes:
[GENERAL] [ENHANCEMENT] [SizeFlexibilityUpdateTest.js] - rm SubscribableMixin