Add asyncToGenerator to the babelHelper #22058
Conversation
facebook-github-bot
added
the
CLA Signed
Libraries/polyfills/babelHelpers.js
Outdated
| // ### asyncToGenerator ### | ||
|
|
||
| function _asyncToGenerator(fn) { | ||
| return function () { |
Libraries/polyfills/babelHelpers.js
Outdated
| function _asyncToGenerator(fn) { | ||
| return function () { | ||
| var gen = fn.apply(this, arguments); | ||
| return new Promise(function (resolve, reject) { |
Libraries/polyfills/babelHelpers.js
Outdated
| if (info.done) { | ||
| resolve(value); | ||
| } else { | ||
| return Promise.resolve(value).then(function (value) { |
There was a problem hiding this comment.
prettier/prettier: Replace function· with ⏎············function
Libraries/polyfills/babelHelpers.js
Outdated
| if (info.done) { | ||
| resolve(value); | ||
| } else { | ||
| return Promise.resolve(value).then(function (value) { |
There was a problem hiding this comment.
no-shadow: 'value' is already declared in the upper scope.
Libraries/polyfills/babelHelpers.js
Outdated
| resolve(value); | ||
| } else { | ||
| return Promise.resolve(value).then(function (value) { | ||
| step('next', value); |
Libraries/polyfills/babelHelpers.js
Outdated
| } else { | ||
| return Promise.resolve(value).then(function (value) { | ||
| step('next', value); | ||
| }, function (err) { |
There was a problem hiding this comment.
prettier/prettier: Replace },·function· with ··},⏎············function
Libraries/polyfills/babelHelpers.js
Outdated
| return Promise.resolve(value).then(function (value) { | ||
| step('next', value); | ||
| }, function (err) { | ||
| step('throw', err); |
Libraries/polyfills/babelHelpers.js
Outdated
| step('next', value); | ||
| }, function (err) { | ||
| step('throw', err); | ||
| }); |
There was a problem hiding this comment.
prettier/prettier: Replace } with ··},⏎··········
Libraries/polyfills/babelHelpers.js
Outdated
| return step('next'); | ||
| }); | ||
| }; | ||
| }; |
There was a problem hiding this comment.
no-extra-semi: Unnecessary semicolon.
Libraries/polyfills/babelHelpers.js
Outdated
| return step('next'); | ||
| }); | ||
| }; | ||
| }; |
Generated by 🚫 dangerJS |
| } | ||
|
|
||
| if (info.done) { | ||
| resolve(value); |
There was a problem hiding this comment.
no-shadow: 'value' is already declared in the upper scope.
|
I don't think this is necessary now that RN 0.57 uses the babel runtime instead of the helpers in this file. See #21283. |
|
Closing as per the last comment, agree this shouldn't be necessary. |
This is an existing problem which is discussed in this issue
Release Notes:
Help reviewers and the release process by writing your own release notes. See below for an example.
[GENERAL] [ENHANCEMENT] [Polyfills] - Add asyncToGenerator to the babelHelper