feat: add custom color for iOS13 segmented control #27643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
the
Type: Enhancement
cpojer
approved these changes
Jan 7, 2020
facebook-github-bot
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @Naturalclar in e8f577e. When will my fix make it into a release? | Upcoming Releases |
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
Summary: Addresses Issue from react-native-segmented-control/segmented-control#16 SegmentedControlIOS changed how it looks in iOS13. This PR allows allows more customization of SegmentedControl for iOS13. ## Changelog [iOS] [Added] - add textColor and backgroundColor props for iOS >=13 Pull Request resolved: facebook#27643 Test Plan: | Before | After | | --- | --- | | <img src="https://user-images.githubusercontent.com/6936373/71608475-e68ff580-2bc4-11ea-9fe4-b85b99130356.png" width="320" /> | <img src="https://user-images.githubusercontent.com/6936373/71608757-dc6ef680-2bc6-11ea-85be-aa31f25ecf36.png" width="320" /> | Differential Revision: D19296783 Pulled By: cpojer fbshipit-source-id: 81a31b2d5ae3085a6fd1874e7d72e75be4c51318
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses Issue from react-native-segmented-control/segmented-control#16
SegmentedControlIOS changed how it looks in iOS13.
This PR allows allows more customization of SegmentedControl for iOS13.
Changelog
[iOS] [Added] - add textColor and backgroundColor props for iOS >=13
Test Plan