Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-native-oss-ios by bumping Xcode to 12.4.0 #31554

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix react-native-oss-ios by bumping Xcode to 12.4.0
Summary:
## Changes
This diff bumps Xcode to 12.4.0 both internally, and in Circle CI.

- According to [Circle CI docs](https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions), their environments support Xcode 12.4.0.
- According to the [Apple Docs](https://developer.apple.com/support/xcode/), Xcode 12.4.0 matches iOS 14.4.

Changelog: [Internal]

Differential Revision: D28547839

fbshipit-source-id: 431100abd5c4709d8bb12cb91d0d085a6240eebf
  • Loading branch information
RSNara authored and facebook-github-bot committed May 19, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 9b7d5a512cfd4294f8f4f97dce9e82f17d80b53d
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ executors:
reactnativeios:
<<: *defaults
macos:
xcode: &_XCODE_VERSION "12.1.0"
xcode: &_XCODE_VERSION "12.4.0"

# -------------------------
# COMMANDS
2 changes: 1 addition & 1 deletion scripts/.tests.env
Original file line number Diff line number Diff line change
@@ -24,7 +24,7 @@ export AVD_ABI=x86
export ANDROID_DISABLE_AVD_TESTS=1

## IOS ##
export IOS_TARGET_OS="14.1"
export IOS_TARGET_OS="14.4"
export IOS_DEVICE="iPhone 8"
export SDK_IOS="iphonesimulator"