Fix/remove default props/android layout drawer #32160
Conversation
facebook-github-bot
added
the
CLA Signed
Base commit: 4f0671b |
Base commit: 4f0671b |
| * ); | ||
| * ``` | ||
| */ | ||
| drawerBackgroundColor: ColorValue, |
There was a problem hiding this comment.
@lunaleaps i think we can remove this because, when a user passes a custom prop to the component it will pick it up and replace the default value which is currently - "white". if we keep it here it would raise an error saying that drawerBackgroundColor is present in "Props"(read only flow interface) and not present inside the props in the DrawerLayoutAndroid Class component.
When the "static props" field was present this wasn't an issue as the class by default added it to the props object.
gradlew.bat
Outdated
| @@ -1,89 +1,89 @@ | |||
| @rem | |||
There was a problem hiding this comment.
Similarly to #32133, you should not add gradlew.bat files to this PR (please don't git add --all otherwise you will add those files).
There was a problem hiding this comment.
yes doing a git add file-name would fix this, but wasnt sure as it appeared after i took a pull form the main branch. so shall i reverse the commit and only push the other relevant files? @cortinico . Not too sure with the exact reason why this kept showing up after the pull.
There was a problem hiding this comment.
gradlew.bat
Outdated
| @@ -1,89 +1,89 @@ | |||
| @rem | |||
There was a problem hiding this comment.
Regarding the .bat files, they were present from the moment i did a rebase from the "main" branch essentially. if you compare the left and right panes there are no changes. So this shouldn't affect the current code, but it is weird that i could not stash/revert these changes after a merge from the upstream main branch.
There was a problem hiding this comment.
There are indeed changes in terms of whitespaces. This is addressed by #31398 and you should not include them in your change as they're unrelated to your PR.
There was a problem hiding this comment.
got it! makes sense thanks for pointing this out 👍🏼
mdaj06
force-pushed
the
fix/removeDefaultProps/AndroidLayoutDrawer
branch
from
45209b1 to
8c25711
Compare
|
The diff for this PR seems to be empty @mdaj06 |
|
@cortinico this branch got closed on a revert so i have addressed all the issues mentioned above in PR #32162 |
|
Gotcha, sorry for the confusion |
Summary
Removed the deaultProps in the DrawerLayoutAndroid file and replaced it with a default value in case props are undefined.
Changelog
[General] [Changed] - Remove defaultProps from the DrawerLayoutAndroid Component.
@lunaleaps this is the fix for issue #31606
Test Plan
Ran test suite