Add volta support to find-node.sh

[liamjones]

Summary

This PR add volta support to find-node.sh for use by scripts/react-native-xcode.sh, scripts/generate-specs.sh, etc.

Changelog

[iOS] [Added] - add volta support to find-node.sh

Test Plan

Manually tested with volta installed node (and relevant change added to the project's package.json). Without this patch, the Bundle React Native code and images Build Phase fails, with it, it succeeds.

Tested with both curl https://get.volta.sh | bash installed and brew install volta. One check works for both because the node shim will always be installed to the same location (and the required environment variable exports are the same also)

Wasn't sure if you'd want the package.json change applied to rn-tester? Shouldn't affect people who don't use volta. Shout if you want me to add it to this PR.

[facebook-github-bot]

Hi @liamjones!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: d123a6f
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,477,119	+0
android	hermes	armeabi-v7a	7,776,517	+0
android	hermes	x86	8,945,994	+0
android	hermes	x86_64	8,890,143	+0
android	jsc	arm64-v8a	9,791,933	+0
android	jsc	armeabi-v7a	8,752,535	+0
android	jsc	x86	9,740,749	+0
android	jsc	x86_64	10,341,651	+0

Base commit: d123a6f
Branch: main

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[facebook-github-bot]

@yungsters has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[liamjones]

This one might need a bit more work.

While the change I've done does add volta support, and it works for builds there's something weird going on with respect to the codegen not finding volta (and I missed that because my first build wasn't via volta) - more info here. So realistically, this doesn't complete support for volta yet.

@yungsters should I close the PR and re-raise it when the issue is resolved?

[cortinico]

LGTM 👍

[facebook-github-bot]

@yungsters merged this pull request in 7658440.