Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix Deadlock in RCTi18nUtil (iOS) (#31032)" (#32574) #32714

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

mmmoussa
Copy link
Contributor

@mmmoussa mmmoussa commented Dec 6, 2021

Summary

This reverts commit fcead14.

This should close #32509 . There was a bug where il8nManager.forceRTL() wouldn't work on app launch, and required an app restart. That was caused by an earlier change (#31032) which should not be necessary (the deadlock it was attempting to fix was actually caused by separate code).

Changelog

[iOS] [Fixed] - Fixed bug where forceRTL did not work on app launch

Pull Request resolved: #32574

Test Plan: Simple revert back to previously working code.

Reviewed By: RSNara

Differential Revision: D32315034

Pulled By: GijsWeterings

fbshipit-source-id: dae6c1f0a2481e53f2f1e80f1ac083947681ef99

[CATEGORY] [TYPE] - Message

Test Plan

…#32574)

Summary:
This reverts commit fcead14.

This should close facebook#32509 . There was a bug where il8nManager.forceRTL() wouldn't work on app launch, and required an app restart. That was caused by an earlier change (facebook#31032) which should not be necessary (the deadlock it was attempting to fix was actually caused by separate code).

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

[iOS] [Fixed] - Fixed bug where forceRTL did not work on app launch

Pull Request resolved: facebook#32574

Test Plan: Simple revert back to previously working code.

Reviewed By: RSNara

Differential Revision: D32315034

Pulled By: GijsWeterings

fbshipit-source-id: dae6c1f0a2481e53f2f1e80f1ac083947681ef99
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2021
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Dec 6, 2021
@pull-bot
Copy link

pull-bot commented Dec 6, 2021

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than main. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on main first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.

Generated by 🚫 dangerJS against 8547b7c

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: bba5e6b

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,943,010 +651,081
android hermes armeabi-v7a 8,477,902 +855,280
android hermes x86 9,362,026 +599,785
android hermes x86_64 9,329,256 +627,881
android jsc arm64-v8a 10,626,440 +946,232
android jsc armeabi-v7a 9,548,852 +881,265
android jsc x86 10,639,736 +1,003,716
android jsc x86_64 11,250,658 +1,017,901

Base commit: bba5e6b

@lunaleaps lunaleaps merged commit 5d7fd00 into facebook:0.66-stable Dec 7, 2021
@mmmoussa mmmoussa deleted the 0.66-stable branch December 7, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants