Fix missing import on New Architecture build script in template #34230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The OS static class is accessed inside app/build.gradle but the import is on the top level Gradle file. This is causing an app created from template to fail building. This is needed to be cherry-picked on the 0.70-stable branch. Changelog: [Android] [Fixed] - Fix missing import on New Architecture build script in template Differential Revision: D37995897 fbshipit-source-id: dd4adc3aadfeabdcf63b522109d299373071d8c8
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D37995897 |
Base commit: e1d17c8 |
|
This pull request was successfully merged by @cortinico in a22f30d. When will my fix make it into a release? | Upcoming Releases |
Base commit: 3188727 |
kelset
pushed a commit
that referenced
this pull request
Jul 27, 2022
Summary: Pull Request resolved: #34230 The OS static class is accessed inside app/build.gradle but the import is on the top level Gradle file. This is causing an app created from template to fail building. This is needed to be cherry-picked on the 0.70-stable branch. Changelog: [Android] [Fixed] - Fix missing import on New Architecture build script in template Reviewed By: cipolleschi Differential Revision: D37995897 fbshipit-source-id: aad22100cee004944c4fa0841f5ef0dfc6ea1e94
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Jul 30, 2022
Fixed/picked in 0.70.0-rc.1 - reactwg/react-native-releases#26 (comment) - facebook/react-native#34230
leotm
added a commit
to leotm/react-native-template-new-architecture
that referenced
this pull request
Jul 30, 2022
* Update dependency react-native to v0.70.0-rc.1 * Revert temp Gradle build fix Fixed/picked in 0.70.0-rc.1 - https://github.com/reactwg/react-native-releases/discussions/26#discussioncomment-3188952 - facebook/react-native#34230 * Revert temp RN 0.70.0-rc.0 patch - Revert/remove stale resolution - Remove stale patch Now on 0.70.0-rc.1 * Upgrade RN pods from 0.70.0-rc.0 to 0.70.0-rc.1 * Upgrade RN files from 0.70.0-rc.0 to 0.70.0-rc.1 Ignore from upgrade-helper local changes not in template - contents.xcworkspacedata from upgrade-helper - project.pbxproj https://react-native-community.github.io/upgrade-helper/?from=0.70.0-rc.0&to=0.70.0-rc.1 * Update ReadMe screenshots Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: LeoTM <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The OS static class is accessed inside app/build.gradle but the import is on
the top level Gradle file. This is causing an app created from template to fail
building.
This is needed to be cherry-picked on the 0.70-stable branch.
Changelog:
[Android] [Fixed] - Fix missing import on New Architecture build script in template
Differential Revision: D37995897