Add fetch's clone function to Request and Response prototypes #3614
Conversation
Fetch includes a cloning function that was not included in the React Native fetch.js. This adds it in so that cloning is available on responses from fetch calls.
|
By analyzing the blame information on this pull request, we identified @sahrens, @brentvatne and @oblador to be potential reviewers. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
@sahrens is there a process for updating fetch.js? Should we have a script that pulls the latest published version and prepends the FB-specific code at the top? |
|
Ok, I'm all signed up! I should be on your list now. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
@naomiajacobs updated the pull request. |
naomiajacobs
changed the title
|
I have no idea if there is a process. @vjeux? I'm fine with pulling this in though. @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/150347778653245/int_phab to review. |
|
There is no process. I just copy and pasted the fetch implementation on github when I imported it. |
ghost
closed this
in
Summary: Fetch includes a cloning function that was not included in the React Native fetch.js. This adds it in so that cloning is available on responses from fetch calls in React Native. The code is taken directly from [fetch](https://github.com/github/fetch/blob/master/fetch.js) on Github. <img width="601" alt="screen shot 2015-10-22 at 11 50 53 am" src="https://cloud.githubusercontent.com/assets/11564650/10675101/304ebe5a-78b3-11e5-9d6b-24ea6d9fb998.png"> <img width="596" alt="screen shot 2015-10-22 at 12 20 08 pm" src="https://cloud.githubusercontent.com/assets/11564650/10675834/4abaf4ee-78b7-11e5-9d34-436290b64b30.png"> Closes facebook#3614 Reviewed By: svcscm Differential Revision: D2600517 Pulled By: sahrens fb-gh-sync-id: d70c5c58e923d997f93bb5aa2d1d90e95d5a75f2
Summary: Fetch includes a cloning function that was not included in the React Native fetch.js. This adds it in so that cloning is available on responses from fetch calls in React Native. The code is taken directly from [fetch](https://github.com/github/fetch/blob/master/fetch.js) on Github. <img width="601" alt="screen shot 2015-10-22 at 11 50 53 am" src="https://cloud.githubusercontent.com/assets/11564650/10675101/304ebe5a-78b3-11e5-9d6b-24ea6d9fb998.png"> <img width="596" alt="screen shot 2015-10-22 at 12 20 08 pm" src="https://cloud.githubusercontent.com/assets/11564650/10675834/4abaf4ee-78b7-11e5-9d34-436290b64b30.png"> Closes facebook#3614 Reviewed By: svcscm Differential Revision: D2600517 Pulled By: sahrens fb-gh-sync-id: d70c5c58e923d997f93bb5aa2d1d90e95d5a75f2
Fetch includes a cloning function that was not included in the React Native fetch.js. This adds it in so that cloning is available on responses from fetch calls in React Native. The code is taken directly from fetch on Github.