rn_codegen: renamed src_prefix to codegen_src_prefix #36866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44857745 |
Base commit: 71506ce |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
Summary: Pull Request resolved: facebook#36866 For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Reviewed By: sammy-SC Differential Revision: D44857745 fbshipit-source-id: 4049432d174021201951b5cf2ecbfa9a100243af
fkgozali
force-pushed
the
export-D44857745
branch
from
e0b1f05 to
9a5b491
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44857745 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
Summary: Pull Request resolved: facebook#36866 For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Reviewed By: sammy-SC Differential Revision: D44857745 fbshipit-source-id: 7516c6b07fe83b310e1f5fb8307d7b8b63d84827
fkgozali
force-pushed
the
export-D44857745
branch
from
9a5b491 to
4799300
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44857745 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44857745 |
fkgozali
added a commit
to fkgozali/react-native
that referenced
this pull request
Apr 11, 2023
Summary: Pull Request resolved: facebook#36866 For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Reviewed By: sammy-SC Differential Revision: D44857745 fbshipit-source-id: 402b8d9fed5793233ad7165c9e1696f659b5f62c
fkgozali
force-pushed
the
export-D44857745
branch
from
4799300 to
1d18bdf
Compare
Summary: Pull Request resolved: facebook#36866 For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Reviewed By: sammy-SC Differential Revision: D44857745 fbshipit-source-id: 0c9f100ecb4c4f29cf02b62b61a5b1a22f91c1f7
|
This pull request was exported from Phabricator. Differential Revision: D44857745 |
fkgozali
force-pushed
the
export-D44857745
branch
from
1d18bdf to
34194af
Compare
|
This pull request has been merged in 9193c4f. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36866 For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Reviewed By: sammy-SC Differential Revision: D44857745 fbshipit-source-id: 475658281a6c2846be42e130f81e23dfcae5856b
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36866 For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent. Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg Reviewed By: sammy-SC Differential Revision: D44857745 fbshipit-source-id: 475658281a6c2846be42e130f81e23dfcae5856b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
For consistency with internal build rules, rename this kwarg. This will make it easier to keep both internal and external usages consistent.
Changelog: [General][Changed] react-native-codegen: Buck-only: renamed src_prefix kwarg
Differential Revision: D44857745