Integrate dev-middleware into start command #39059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
Base commit: 211f314 |
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 0baf304f2554deab4eaf59938d903cf7b691e9c1
huntie
force-pushed
the
export-D47226421
branch
from
66b10ec to
69b944b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 9d80cc68d68260cb88d090b4a3ca2624d1b73bbc
huntie
force-pushed
the
export-D47226421
branch
from
69b944b to
709d0d4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 2b96b50591cd0529e3b7f73732f1f8057034860f
huntie
force-pushed
the
export-D47226421
branch
from
709d0d4 to
886a5bc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 61a1c39d4f2d1a5ea0ffbc247b7b5f58e57ee8eb
huntie
force-pushed
the
export-D47226421
branch
from
886a5bc to
2fe609d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 6f668afa788541f35450173c04ee4b441cbbe07a
huntie
force-pushed
the
export-D47226421
branch
from
2fe609d to
13bf1a0
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 0e9fd2da35cdd83086ec949200be62aa25fda78c
huntie
force-pushed
the
export-D47226421
branch
from
13bf1a0 to
65e7437
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: ef43782af9464d7f11cbe92eafc10d241272a9d2
huntie
force-pushed
the
export-D47226421
branch
from
65e7437 to
092eb5b
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 774277eea25ae958bddd3a4b32e37e7ea6dbdcea
huntie
force-pushed
the
export-D47226421
branch
from
092eb5b to
d0042e2
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 5573a246f56fa099a6e1b036efb39001caeaf1bc
huntie
force-pushed
the
export-D47226421
branch
from
d0042e2 to
ebe8d5a
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 41ce0210bbf42a4d82d21fd4d556b7ceafea3c4a
huntie
force-pushed
the
export-D47226421
branch
from
ebe8d5a to
744f374
Compare
thymikee
reviewed
Aug 21, 2023
Comment on lines
26
to
27
| "@react-native-community/cli-server-api": "12.0.0-alpha.9", | ||
| "@react-native-community/cli-tools": "12.0.0-alpha.9", |
There was a problem hiding this comment.
do we plan to eventually move these entirely or to some extent to the community-cli-plugin?
There was a problem hiding this comment.
Yes, but not with any near term priority.
- This is started in Simplify occupied port handling in start command #39078 where I'm trying to decouple a little from
cli-server-api. (Though no short term plans to fully decouple). - And for
cli-server-apiwe're looking to slowly migrate/replace debugging endpoints into@react-native/dev-middleware— we'll probably do this after the 0.73 JSC Remote Debugging deprecation.
⬇️ Apologies for the amount of merge attempts here, trying to line this up with our internal CI and infra 😅. Landing soon!
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 22ac9bfee07e9d97ac520a3a03935cf00cec675b
huntie
force-pushed
the
export-D47226421
branch
from
744f374 to
fe8cace
Compare
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 21, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 892691568dd191ca4702460d75415a79de3673d3
huntie
force-pushed
the
export-D47226421
branch
from
fe8cace to
34bee77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: fac7dc9c3d10043cd42a72dd7e768dcff8564d52
huntie
force-pushed
the
export-D47226421
branch
from
34bee77 to
eba120e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: b422e1b88d59cbe278dab25e461f62a548f2e9e6
huntie
force-pushed
the
export-D47226421
branch
from
eba120e to
098d5a1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: 5322b4e2dbc7f2eb83fa8351b635d9fb22ad8e02
huntie
force-pushed
the
export-D47226421
branch
from
098d5a1 to
dd466d1
Compare
Summary: Pull Request resolved: facebook#39059 ## Context RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641 ## Changes This change: - Links the new `react-native/dev-middleware` endpoints into the recently migrated `react-native start` command. - Adds `react-native/community-cli-plugin` (the migrated [`cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro)) as a dependency of `react-native`, and hooks in these versions of the `start`, `bundle`, and `ram-bundle` commands via `react-native.config.js`. Functionally, this means that the new `/open-debugger` endpoint is available on the dev server started by `react-native start` (not yet linked into any UI). After this PR is merged, the new `community-cli-plugin` package is "linked" and we can remove `cli-plugin-metro` from `react-native-community/cli`: react-native-community/cli#2055. Changelog: [Internal] Reviewed By: motiz88 Differential Revision: D47226421 fbshipit-source-id: eee439daf7801a847eb3db9175f447e785230ed6
|
This pull request was exported from Phabricator. Differential Revision: D47226421 |
huntie
force-pushed
the
export-D47226421
branch
from
dd466d1 to
e7d700d
Compare
|
This pull request was successfully merged by @huntie in 3c943bb. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
RFC: Decoupling Flipper from React Native core: react-native-community/discussions-and-proposals#641
Changes
This change:
@react-native/dev-middlewareendpoints into the recently migratedreact-native startcommand.@react-native/community-cli-plugin(the migratedcli-plugin-metro) as a dependency ofreact-native, and hooks in these versions of thestart,bundle, andram-bundlecommands viareact-native.config.js.Functionally, this means that the new
/open-debuggerendpoint is available on the dev server started byreact-native start(not yet linked into any UI).After this PR is merged, the new
community-cli-pluginpackage is "linked" and we can removecli-plugin-metrofrom@react-native-community/cli: react-native-community/cli#2055.Changelog: [Internal]
Reviewed By: motiz88
Differential Revision: D47226421