Implement version parsing and connect to RNTester #39502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49270012 |
|
This pull request was exported from Phabricator. Differential Revision: D49270012 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 55f324ac4dec0e23af8b231bb85703d9e53d95e0
cipolleschi
force-pushed
the
export-D49270012
branch
from
d6df7cf to
8e2e361
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49270012 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 010c735b77c6bcbff5b442d1a454571209738c5d
cipolleschi
force-pushed
the
export-D49270012
branch
from
8e2e361 to
d91e42d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49270012 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Sep 18, 2023
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 0a829d3aa75ecd7fb45c1f40b03f5a959744f92e
cipolleschi
force-pushed
the
export-D49270012
branch
from
d91e42d to
8e333f7
Compare
Base commit: 47de1f6 |
Summary: When working on RNTeaster, we discovered that the Kotlin migration. broke something. This diff make sure we can test RNTester ## Changelog: [Internal] - Make RNTester's New Architecture Example execute again Differential Revision: https://internalfb.com/D49154282 fbshipit-source-id: c73430dcdb54a5e7f5381a22af0387a982c03510
Summary: Pull Request resolved: facebook#39501 This change introduce a new model to parse the React Native package.json. The objects are not connected but they will be used in the next diff ## Changelog: [Android][Added] - Add a couple of types in the RNGP for json parsing. Differential Revision: https://internalfb.com/D49270044 fbshipit-source-id: 65ffcab8671c38b4a1e9f1c63d441660b9b8869b
Summary: Pull Request resolved: facebook#39502 This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture. This change depends on [this CLI's PR](react-native-community/cli#2076). ## Changelog: [Android][Added] - Parse RN Version to decide whether to enable the New Arch or not. Reviewed By: cortinico Differential Revision: D49270012 fbshipit-source-id: 1dca14650a2a4de5b7d7caaa4043bb80845436d5
|
This pull request was exported from Phabricator. Differential Revision: D49270012 |
cipolleschi
force-pushed
the
export-D49270012
branch
from
8e333f7 to
17c322e
Compare
|
This pull request has been merged in 29adb8d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the parsing of the package.json to retrieve the version of react native and it matches it against a regex to decide whether to enable or not the New Architecture.
This change depends on this CLI's PR.
Changelog:
[Android][Added] - Parse RN Version to decide whether to enable the New Arch or not.
Reviewed By: cortinico
Differential Revision: D49270012