Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-bump AGP to 8.1.2 #39958

Closed
wants to merge 1 commit into from
Closed

Un-bump AGP to 8.1.2 #39958

wants to merge 1 commit into from

Conversation

cortinico
Copy link
Contributor

Summary:
I'm reverting the change of AGP from 8.2 beta to 8.1 as we don't need 8.2
Using 8.2 beta forces us to use Android Studio beta, which is actually not necessary.

Changelog:
[Android] [Changed] - Bump AGP to 8.1.2

Differential Revision: D50016572

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50016572

cortinico added a commit to cortinico/react-native that referenced this pull request Oct 6, 2023
@cortinico @facebook-github-bot
Un-bump AGP to 8.1.2 (facebook#39958)
b584d80 
Summary:

I'm reverting the change of AGP from 8.2 beta to 8.1 as we don't need 8.2
Using 8.2 beta forces us to use Android Studio beta, which is actually not necessary.

Changelog:
[Android] [Changed] - Bump AGP to 8.1.2

Reviewed By: yungsters

Differential Revision: D50016572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50016572

@analysis-bot
Copy link

analysis-bot commented Oct 6, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,227,337 -4,095
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,599,557 -1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ebd2f67
Branch: main

@cortinico @facebook-github-bot
Un-bump AGP to 8.1.2 (facebook#39958)
aa4571f 
Summary:

I'm reverting the change of AGP from 8.2 beta to 8.1 as we don't need 8.2
Using 8.2 beta forces us to use Android Studio beta, which is actually not necessary.

Changelog:
[Android] [Changed] - Bump AGP to 8.1.2

Reviewed By: yungsters

Differential Revision: D50016572
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D50016572

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 6, 2023
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 22388fe.

@NickGerleman
Copy link
Contributor

Ooh nice. Specifying NDK 26 didn’t work when I tested with AGP 8.1 before, but I guess maybe support was added in a patch release, or something changed service side?

@cortinico
Copy link
Contributor Author

Specifying NDK 26 didn’t work when I tested with AGP 8.1 before, but I guess maybe support was added in a patch release, or something changed service side?

Not that I'm aware of. There are also no release notes for 8.1.2 so I can't say if this got fixed there or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cortinico @facebook-github-bot @analysis-bot @NickGerleman