Fix unsafe async call in CatalystInstance callback #40861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50224974 |
Base commit: 3a26e55 |
Summary: Reference `jobj_` from the async callback is unsafe, as the Java counterpart may have been deallocated by the time it's executed. Instead move the async call to Java. Note that this method doesn't actually do anything in Fabric, it's used by the old renderer only. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D50224974
javache
force-pushed
the
export-D50224974
branch
from
19e3dc2 to
f1ba09a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50224974 |
|
This pull request has been merged in 95d09d3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Reference
jobj_from the async callback is unsafe, as the Java counterpart may have been deallocated by the time it's executed. Instead move the async call to Java.Note that this method doesn't actually do anything in Fabric, it's used by the old renderer only.
Changelog: [Internal]
Differential Revision: D50224974