Fix symbol not found _jump_fcontext with use_frameworks! #42230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52658197 |
cipolleschi
force-pushed
the
export-D52658197
branch
from
ecff2d4 to
ec85285
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 11, 2024
) Summary: While developing Xcode 15, Apple reimplemented the linker. In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15. To fix that, we make Apple create new compiler flags (`-ld_classic`) to have a backward compatible linker. In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore. But now, if we pass `-ld_classic` to the linker and we have an app that is using `use_framworks!`, that app crashes at startup. This change remove the flags if the Xcode that is used is 15.1 or greater. *Note:* The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native. This Fixes facebook#39945 ## Changelog: [Internal] - Do not add the `-ld_classic` flag if the app is built with Xcode 15.1 or greater. Reviewed By: cortinico Differential Revision: D52658197
|
This pull request was exported from Phabricator. Differential Revision: D52658197 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 11, 2024
) Summary: While developing Xcode 15, Apple reimplemented the linker. In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15. To fix that, we make Apple create new compiler flags (`-ld_classic`) to have a backward compatible linker. In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore. But now, if we pass `-ld_classic` to the linker and we have an app that is using `use_framworks!`, that app crashes at startup. This change remove the flags if the Xcode that is used is 15.1 or greater. *Note:* The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native. This Fixes facebook#39945 ## Changelog: [Internal] - Do not add the `-ld_classic` flag if the app is built with Xcode 15.1 or greater. Reviewed By: cortinico Differential Revision: D52658197
cipolleschi
force-pushed
the
export-D52658197
branch
from
ec85285 to
e9c5005
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52658197 |
) Summary: While developing Xcode 15, Apple reimplemented the linker. In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15. To fix that, we make Apple create new compiler flags (`-ld_classic`) to have a backward compatible linker. In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore. But now, if we pass `-ld_classic` to the linker and we have an app that is using `use_framworks!`, that app crashes at startup. This change remove the flags if the Xcode that is used is 15.1 or greater. *Note:* The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native. This Fixes facebook#39945 ## Changelog: [Internal] - Do not add the `-ld_classic` flag if the app is built with Xcode 15.1 or greater. Reviewed By: cortinico Differential Revision: D52658197
cipolleschi
force-pushed
the
export-D52658197
branch
from
e9c5005 to
8848c0d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52658197 |
|
This pull request has been merged in abad576. |
gokul1099
pushed a commit
to gokul1099/react-native-visionos
that referenced
this pull request
Jan 17, 2024
) Summary: Pull Request resolved: facebook#42230 While developing Xcode 15, Apple reimplemented the linker. In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15. To fix that, we make Apple create new compiler flags (`-ld_classic`) to have a backward compatible linker. In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore. But now, if we pass `-ld_classic` to the linker and we have an app that is using `use_framworks!`, that app crashes at startup. This change remove the flags if the Xcode that is used is 15.1 or greater. *Note:* The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native. This Fixes facebook#39945 ## Changelog: [Internal] - Do not add the `-ld_classic` flag if the app is built with Xcode 15.1 or greater. Reviewed By: cortinico Differential Revision: D52658197 fbshipit-source-id: 37d6bc895921c0fc3661f301870477191e7e42b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
While developing Xcode 15, Apple reimplemented the linker.
In Xcode 15.0, the linker was making old iOS (< 15) crash when they were built using Xcode 15.
To fix that, we make Apple create new compiler flags (
-ld_classic) to have a backward compatible linker.In Xcode 15.1, Apple fixed that behavior, so the flags should not be required anymore.
But now, if we pass
-ld_classicto the linker and we have an app that is usinguse_framworks!, that app crashes at startup.This change remove the flags if the Xcode that is used is 15.1 or greater.
Note: The previous change added the flags to Hermes as well. I tested this fix in a configuration where Hermes has the flags and React Native does not, and it works. So we are removing the flags only from React Native.
This Fixes #39945
Changelog:
[Internal] - Do not add the
-ld_classicflag if the app is built with Xcode 15.1 or greater.Differential Revision: D52658197