Make Modal's onDismiss work on Fabric.
#42601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 22, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
2425376 to
bc7a7af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 22, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
bc7a7af to
e86038c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
Base commit: b8778ab |
cipolleschi
force-pushed
the
export-D52959996
branch
from
e86038c to
5dee28b
Compare
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
Comment on lines
278
to
280
| if (Platform.OS === 'ios') { | ||
| this.setState({isRendering: false}, () => { | ||
| if (this.props.onDismiss) { | ||
| this.props.onDismiss(); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Question: Wouldn't it be better from an OOT platform standpoint to use early return? If we would check Platform.OS === 'android' and return. Then no changes would be needed for macOS to support it.
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
5dee28b to
c7f3b0c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
c7f3b0c to
aae1891
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
aae1891 to
9e849ca
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
9e849ca to
1a45258
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 23, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
1a45258 to
14e8da9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
befed28 to
cbaeffb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 24, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
cbaeffb to
7b20f9d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 25, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
7b20f9d to
cc01266
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 25, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
cc01266 to
bdb85f3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Jan 31, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
bdb85f3 to
4ec1a95
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Feb 7, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
4ec1a95 to
ba96111
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
cipolleschi
added a commit
to cipolleschi/react-native
that referenced
this pull request
Feb 7, 2024
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
ba96111 to
44a45f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
Summary: After S390064, the OnDismiss event for Modal from D52445670 was reverted. The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything. The most important thing for our short term goal is to make the `OnDismiss` work only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless). We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs. ## The Problem: The reason why the onDismiss event does not work is because, as soon as the `visible` property is turned to `false`, the component is removed by the React tree. When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired. ## The Solution: We made this work by "delaying" when the component need to be removed from the reacat Tree. Rather then rendering or node or not based on the `visible` props, we are introducing a `State` object that keeps track when the Modal is rendered or not. The `state.isRendering` property is set to `true` when the `visible` prop is set to `true`. For iOS, when `visible` prop is set to `false`, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set the `state.isRendering` property to false and the Modal can be considered dismissed. Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented. ## Changelog: [iOS][Fixed] - `onDismiss` now work on iOS with Fabric, in both Bridge and Bridgeless mode. Reviewed By: sammy-SC Differential Revision: D52959996
cipolleschi
force-pushed
the
export-D52959996
branch
from
44a45f9 to
7369719
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52959996 |
|
This pull request has been merged in c7a0dff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After S390064, the OnDismiss event for Modal from D52445670 was reverted.
The diff was too big and caused the SEV, so we are trying to reimplement it gradually to make sure we don't brake anything.
The most important thing for our short term goal is to make the
OnDismisswork only for iOS (following the official docs, Android never supported it) for Fabric (Bridge and Bridgeless).We also want to minimize the changes t the JS infrastructure, so we are trying not to alter the JS APIs.
The Problem:
The reason why the onDismiss event does not work is because, as soon as the
visibleproperty is turned tofalse, the component is removed by the React tree.When this happens, Fabric deallocate the ShadowNode and the EventEmitter. Therefore, the event is not fired.
The Solution:
We made this work by "delaying" when the component need to be removed from the reacat Tree.
Rather then rendering or node or not based on the
visibleprops, we are introducing aStateobject that keeps track when the Modal is rendered or not.The
state.isRenderingproperty is set totruewhen thevisibleprop is set totrue.For iOS, when
visibleprop is set tofalse, instead, we wait for the Native side to actually dismiss the View and to invoke the event. When the event is fired, we manually set thestate.isRenderingproperty to false and the Modal can be considered dismissed.Notice that this makes also useless to have the Modal Native's snapshot to simulate that the modal is still presented.
Changelog:
[iOS][Fixed] -
onDismissnow work on iOS with Fabric, in both Bridge and Bridgeless mode.Differential Revision: D52959996