Add C++20 std::span-based APIs for function arguments #43489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54901847 |
motiz88
force-pushed
the
export-D54901847
branch
from
19870a0 to
7cbce63
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54901847 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 14, 2024
Summary: Changelog: [General][Changed] - Add `std::span` methods to `jsi::Function` when compiled as C++20 Adds `std::span<const jsi::Value>` overloads to public JSI methods that currently accept (or are designed to emit) `const jsi::Value* args, size_t count` for a dynamically-sized span of function arguments. These are: * `Function::call` * `Function::callWithThis` * `Function::callAsConstructor` * `Function::createFromHostFunction` We also add a `HostFunctionTypeWithSpanArgs` typedef (naming feedback welcome!) to serve a similar purpose to the existing `HostFunctionType`. ## Backwards compatibility * The new APIs are compiled conditionally to support pre-C++20 compilers. * No overloads are removed. * The new overloads are implemented as `inline` wrappers over the pointer+size versions. No change is made to the JSI contract for implementers (i.e. no new overloads, virtual or otherwise, are added to `Runtime`). Differential Revision: D54901847
motiz88
force-pushed
the
export-D54901847
branch
from
7cbce63 to
3bebe76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54901847 |
motiz88
force-pushed
the
export-D54901847
branch
from
3bebe76 to
61ffa58
Compare
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 15, 2024
Summary: Changelog: [General][Changed] - Add `std::span` methods to `jsi::Function` when compiled as C++20 Adds `std::span<const jsi::Value>` overloads to public JSI methods that currently accept (or are designed to emit) `const jsi::Value* args, size_t count` for a dynamically-sized span of function arguments. These are: * `Function::call` * `Function::callWithThis` * `Function::callAsConstructor` * `Function::createFromHostFunction` ## Backwards compatibility * The new APIs are compiled conditionally to support pre-C++20 compilers. * No overloads are removed. * The new overloads are implemented as `inline` wrappers over the pointer+size versions. * No change is made to the JSI contract for implementers (i.e. no new overloads, virtual or otherwise, are added to `Runtime`). Differential Revision: D54901847
|
This pull request was exported from Phabricator. Differential Revision: D54901847 |
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 15, 2024
Summary: Changelog: [General][Changed] - Add `std::span` methods to `jsi::Function` when compiled as C++20 Adds `std::span<const jsi::Value>` overloads to public JSI methods that currently accept (or are designed to emit) `const jsi::Value* args, size_t count` for a dynamically-sized span of function arguments. These are: * `Function::call` * `Function::callWithThis` * `Function::callAsConstructor` * `Function::createFromHostFunction` ## Backwards compatibility * The new APIs are compiled conditionally to support pre-C++20 compilers. * No overloads are removed. * The new overloads are implemented as `inline` wrappers over the pointer+size versions. * No change is made to the JSI contract for implementers (i.e. no new overloads, virtual or otherwise, are added to `Runtime`). Differential Revision: D54901847
motiz88
force-pushed
the
export-D54901847
branch
from
61ffa58 to
3757f82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54901847 |
Summary: Changelog: [General][Changed] - Add `std::span` methods to `jsi::Function` when compiled as C++20 Adds `std::span<const jsi::Value>` overloads to public JSI methods that currently accept (or are designed to emit) `const jsi::Value* args, size_t count` for a dynamically-sized span of function arguments. These are: * `Function::call` * `Function::callWithThis` * `Function::callAsConstructor` * `Function::createFromHostFunction` ## Backwards compatibility * The new APIs are compiled conditionally to support pre-C++20 compilers. * No overloads are removed, except for `createFromHostFunction` (which has been folded into the template implementation). * The new overloads are implemented as `inline` wrappers over the pointer+size versions. * No change is made to the JSI contract for implementers (i.e. no new overloads, virtual or otherwise, are added to `Runtime`). Differential Revision: D54901847
motiz88
force-pushed
the
export-D54901847
branch
from
3757f82 to
6513db1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54901847 |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
react-native-bot
added
the
Stale
|
This PR was closed because it has been stalled for 7 days with no activity. |
react-native-bot
removed
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D54901847
Changelog: [General][Changed] - Add
std::spanmethods tojsi::Functionwhen compiled as C++20Adds
std::span<const jsi::Value>overloads to public JSI methods that currently accept (or are designed to emit)const jsi::Value* args, size_t countfor a dynamically-sized span of function arguments.These are:
Function::callFunction::callWithThisFunction::callAsConstructorFunction::createFromHostFunctionWe also add a
HostFunctionTypeWithSpanArgstypedef (naming feedback welcome!) to serve a similar purpose to the existingHostFunctionType.Backwards compatibility
inlinewrappers over the pointer+size versions. No change is made to the JSI contract for implementers (i.e. no new overloads, virtual or otherwise, are added toRuntime).