Backport fix for Ccache from 0.74 to main #44089
Conversation
Summary: While doing the release of 0.74.0-RC.9, we encountered some failures while building because the committed project had some new flags that have been added by cocoapods and that required Ccache. However, Ccache is not a hard requirement to run React Native and the build started failing on systems that does not have ccache installed. That happened because we were missing the piece of code that removed Ccache from the project in case the tool is not installed in the system. We already committed such commit in the stable branch of 0.74, with [this commit](facebook@2b18fdf). This change will port the same fix in main. ## Changelog [iOS][Fixed] - Make sure to remove ccache scripts when ccache is not installed Differential Revision: D56140015
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56140015 |
|
This pull request has been merged in 6dd83cb. |
|
This pull request was successfully merged by @cipolleschi in 6dd83cb. When will my fix make it into a release? | How to file a pick request? |
|
Thanks a lot for tackling this heads on. I do find the message a bit confusing, if I don't have ccache installed, it feels weird to see:
The intent of the original PR was to log nothing at all if developers didn't have ccache 🤔 Regarding
This is indeed unexpected, do you have a link for such a failure? Is the generated Xcode project transferred between macines? I would love to learn how that could happen with the changes introduced in #42051 |
Summary:
While doing the release of 0.74.0-RC.9, we encountered some failures while building because the committed project had some new flags that have been added by cocoapods and that required Ccache.
However, Ccache is not a hard requirement to run React Native and the build started failing on systems that does not have ccache installed.
That happened because we were missing the piece of code that removed Ccache from the project in case the tool is not installed in the system.
We already committed such commit in the stable branch of 0.74, with this commit. This change will port the same fix in main.
Changelog
[iOS][Fixed] - Make sure to remove ccache scripts when ccache is not installed
Differential Revision: D56140015