Delete pre-allocated views that were never mounted on the screen #46473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 12, 2024
…ebook#46473) Summary: Pull Request resolved: facebook#46473 This diff extends the renderer of react native to ensure that pre-allocated views that were never mounted on the screen are deleted as soon as the shadow node is deleted from JS This feature is controlled by the ReactNativeFeatureFlag: enableDeletionOfUnmountedViews changelog: [internal] internal Reviewed By: javache Differential Revision: D62559190
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
mdvacca
force-pushed
the
export-D62559190
branch
from
dc59155 to
2389bf7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 12, 2024
…ebook#46473) Summary: Pull Request resolved: facebook#46473 This diff extends the renderer of react native to ensure that pre-allocated views that were never mounted on the screen are deleted as soon as the shadow node is deleted from JS This feature is controlled by the ReactNativeFeatureFlag: enableDeletionOfUnmountedViews changelog: [internal] internal Reviewed By: javache Differential Revision: D62559190
mdvacca
force-pushed
the
export-D62559190
branch
from
2389bf7 to
6f5c222
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
2 similar comments
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 14, 2024
…ebook#46473) Summary: Pull Request resolved: facebook#46473 This diff extends the renderer of react native to ensure that pre-allocated views that were never mounted on the screen are deleted as soon as the shadow node is deleted from JS This feature is controlled by the ReactNativeFeatureFlag: enableDeletionOfUnmountedViews changelog: [internal] internal Reviewed By: javache Differential Revision: D62559190
mdvacca
force-pushed
the
export-D62559190
branch
from
6f5c222 to
7ebd9e0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
mdvacca
added a commit
to mdvacca/react-native
that referenced
this pull request
Sep 14, 2024
…ebook#46473) Summary: Pull Request resolved: facebook#46473 This diff extends the renderer of react native to ensure that pre-allocated views that were never mounted on the screen are deleted as soon as the shadow node is deleted from JS This feature is controlled by the ReactNativeFeatureFlag: enableDeletionOfUnmountedViews changelog: [internal] internal Reviewed By: javache Differential Revision: D62559190
mdvacca
force-pushed
the
export-D62559190
branch
from
7ebd9e0 to
2958725
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
…ebook#46473) Summary: Pull Request resolved: facebook#46473 This diff extends the renderer of react native to ensure that pre-allocated views that were never mounted on the screen are deleted as soon as the shadow node is deleted from JS This feature is controlled by the ReactNativeFeatureFlag: enableDeletionOfUnmountedViews changelog: [internal] internal Reviewed By: javache Differential Revision: D62559190
mdvacca
force-pushed
the
export-D62559190
branch
from
2958725 to
0887776
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62559190 |
|
This pull request has been merged in 6dbbbe3. |
|
This pull request was successfully merged by @mdvacca in 6dbbbe3 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff extends the renderer of react native to ensure that pre-allocated views that were never mounted on the screen are deleted as soon as the shadow node is deleted from JS
This feature is controlled by the ReactNativeFeatureFlag: enableDeletionOfUnmountedViews
changelog: [internal] internal
Reviewed By: javache
Differential Revision: D62559190