Add new dangerouslyForceOverride method to feature flags #46963
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64186262 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 10, 2024
) Summary: Changelog: [internal] This introduces a new method in `ReactNativeFeatureFlags` to force setting overrides without triggering any errors. This is partially equivalent to calling `dangerouslyReset` and `override` but completely removing the errors that could be caused by race conditions. Differential Revision: D64186262
rubennorte
force-pushed
the
export-D64186262
branch
from
42191a5 to
9d591c1
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 10, 2024
) Summary: Changelog: [internal] This introduces a new method in `ReactNativeFeatureFlags` to force setting overrides without triggering any errors. This is partially equivalent to calling `dangerouslyReset` and `override` but completely removing the errors that could be caused by race conditions. Differential Revision: D64186262
rubennorte
force-pushed
the
export-D64186262
branch
from
9d591c1 to
96f7e92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64186262 |
rubennorte
force-pushed
the
export-D64186262
branch
from
96f7e92 to
9d591c1
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 10, 2024
) Summary: Changelog: [internal] This introduces a new method in `ReactNativeFeatureFlags` to force setting overrides without triggering any errors. This is partially equivalent to calling `dangerouslyReset` and `override` but completely removing the errors that could be caused by race conditions. Reviewed By: mdvacca Differential Revision: D64186262
rubennorte
force-pushed
the
export-D64186262
branch
from
9d591c1 to
d5aa3e9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64186262 |
) Summary: Changelog: [internal] This introduces a new method in `ReactNativeFeatureFlags` to force setting overrides without triggering any errors (they're returned a string instead to be handled in userland). This is partially equivalent to calling `dangerouslyReset` and `override` but completely avoids the hard crashes that could be caused by race conditions. Reviewed By: javache, rshest Differential Revision: D64186262
rubennorte
force-pushed
the
export-D64186262
branch
from
d5aa3e9 to
3560c0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64186262 |
|
This pull request was successfully merged by @rubennorte in c86b5c1 When will my fix make it into a release? | How to file a pick request? |
|
This pull request has been merged in c86b5c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This introduces a new method in
ReactNativeFeatureFlagsto force setting overrides without triggering any errors. This is partially equivalent to callingdangerouslyResetandoverridebut completely removing the errors that could be caused by race conditions.Differential Revision: D64186262