Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up network module tests #48160

Closed
wants to merge 3 commits into from
Closed

Conversation

tdn120
Copy link

@tdn120 tdn120 commented Dec 6, 2024

Summary:
Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Differential Revision: D66898956

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 9, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 9, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 9, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 10, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 10, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 12, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 13, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 13, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 13, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 13, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 13, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 16, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
Thomas Nardone added 3 commits December 16, 2024 06:06
Summary:

Changelog: [Android][Added] Add mockito-kotlin for Kotlin unit testing

Reviewed By: cortinico

Differential Revision: D66897263
Summary:

Fix the setup for ignored tests and re-enable them.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D66897564
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66898956

tdn120 pushed a commit to tdn120/react-native that referenced this pull request Dec 16, 2024
Summary:

Shift to mockito-kotlin and fix ReactCookieJarContainerTest so it's not just testing a mock.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D66898956
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Dec 16, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 3960a2d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants