Improve E2E Stability for Android #48286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67276601 |
Summary: This change bump maestro to the latest version as it present better reporting. ## Changelog: [Internal] - Bump maestro to 1.39.5 Reviewed By: fabriziocucci Differential Revision: D67273486
Summary: While working on Maestro E2E I realized that we were waiting for Metro to start even when metro was not running. This moves the waiting only when metro is actually started. I also added another waiting point as it takes several seconds for the app to load the bundle from metro the first time. Subsequent attempts are faster as the metro cache is warm. ## Changelog: [Internal] - Improve metro waiting times in E2E Reviewed By: fabriziocucci Differential Revision: D67273648
Summary: In an attempt to improve times and stability, I bumped the android machine to an ubuntu with 4 cores. Sometimes the emulator can hang, so i set a timeout for the E2E tests executions of 1 hours to avoid wasting money in CI ## Changelog [Internal] - Bump Android machine and add timeout Reviewed By: fabriziocucci Differential Revision: D67273842
Summary: The text tests has 2 issues: * on iOS, the Text cell was sometimes rendered below the tabbar, with a small percentage visible. When this happens, the test was actually moving to a different tab rather then navigating to the Text screen * on Android, sometimes navigation took too long and a scroll command was issued. This moved the screen away from the right screen we wanted to test. This change fixes both issues by ensuring that the Text cell is 100% visible (not behind the tabbar) and by ensuring that the title "Text" is visible in Android, so the navigatin has actually happened ## Changelog: [Internal] - Fix Text tests Reviewed By: fabriziocucci Differential Revision: D67274009
Summary: This change bumps the specs for the Android E2E tests. This has been reported to improve the stability of the tests. We need to keep part of the `flatlist.yml` commented as it creates an issue with Maestro as it takes too much memory. I'll reach out to the people working on Maestro to try and understand what's going on there. ## Changelog: [Internal] - Improve android Stability and reenable E2E tests on main Reviewed By: fabriziocucci Differential Revision: D67276601
cipolleschi
force-pushed
the
export-D67276601
branch
from
75f6e57 to
e9c8d6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67276601 |
|
This pull request has been merged in 03b9f04. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change bumps the specs for the Android E2E tests. This has been reported to improve the stability of the tests.
We need to keep part of the
flatlist.ymlcommented as it creates an issue with Maestro as it takes too much memory.I'll reach out to the people working on Maestro to try and understand what's going on there.
Changelog:
[Internal] - Improve android Stability and reenable E2E tests on main
Differential Revision: D67276601