Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RN][0.74] Fix ruby for CI #48885

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[RN][0.74] Fix ruby for CI #48885

merged 1 commit into from
Jan 23, 2025

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jan 23, 2025 •
edited
Loading

Summary:

Ruby has released a version of concurrent-ruby that is broken. This change pin the version to a working one.

Changelog:

[iOs][Changed] - Pin concurrent-ruby to 1.3.4

Test Plan:

CircleCI is green

@cipolleschi cipolleschi changed the base branch from main to 0.74-stable January 23, 2025 11:53
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jan 23, 2025
@cipolleschi cipolleschi force-pushed the cipolleschi/fix-ruby-0.74 branch from 4ff65d6 to 3e01b59 Compare January 23, 2025 11:55
@cipolleschi cipolleschi changed the title cipolleschi/fix ruby 0.74 [RN][0.74] Fix ruby for CI Jan 23, 2025
@cipolleschi cipolleschi marked this pull request as ready for review January 23, 2025 11:55
@cipolleschi cipolleschi requested a review from cortinico January 23, 2025 11:56
@cortinico cortinico merged commit 1c80702 into 0.74-stable Jan 23, 2025
37 of 40 checks passed
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,898,830 -3,456,026
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,252,630 -3,297,361
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: fcd526d
Branch: main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico Awaiting requested review from cortinico

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request
Projects
None yet
Milestone
No milestone
5 participants
@cipolleschi @analysis-bot @cortinico @facebook-github-bot @react-native-bot