[Docs] Fix scrolling issue on iOS devices. #7731
Conversation
|
By analyzing the blame information on this pull request, we identified @vjeux and @janicduplessis to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
Thanks!! |
ghost
added
GH Review: accepted
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
added
Import Failed
and removed
Import Started
|
I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification. |
|
Import failed because of a merge conflict. |
|
what @janicduplessis said, would you mind rebasing? |
|
@Andreyco updated the pull request. |
1 similar comment
|
@Andreyco updated the pull request. |
|
@janicduplessis @vjeux sorry for little delay, fork is up to date |
|
@facebook-github-bot shipit |
ghost
added
the
Import Started
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
|
fbobjc/Libraries/FBReactKit/js/react-native-github/website/src/react-native/css/react-native.css |
|
I see, but have no idea why it's failing... Any heads up? TY |
|
I think that the issue is that when we do the patch, it's against the 9 days ago version and not master. Could you update it such it is only one commit on-top of master?
|
It was not possible to scroll due to overlaying (and visually not present) docs navigation layer.
|
@Andreyco updated the pull request. |
|
PR is single commit and on top of master branch. |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
Summary: It was not possible to scroll due to overlaying (and visually not present) docs navigation layer. Fixes issue introduced in PR #7669, see this [comment](#7669 (comment)) Additionally, script makes sure only single target is "in" and closes any other target with "in" state. Closes #7731 Differential Revision: D3344927 Pulled By: vjeux fbshipit-source-id: b2c64d90a2a6e531a9be79b936d6a5da61a69b22
Summary: It was not possible to scroll due to overlaying (and visually not present) docs navigation layer. Fixes issue introduced in PR facebook#7669, see this [comment](facebook#7669 (comment)) Additionally, script makes sure only single target is "in" and closes any other target with "in" state. Closes facebook#7731 Differential Revision: D3344927 Pulled By: vjeux fbshipit-source-id: b2c64d90a2a6e531a9be79b936d6a5da61a69b22
Summary: It was not possible to scroll due to overlaying (and visually not present) docs navigation layer. Fixes issue introduced in PR facebook#7669, see this [comment](facebook#7669 (comment)) Additionally, script makes sure only single target is "in" and closes any other target with "in" state. Closes facebook#7731 Differential Revision: D3344927 Pulled By: vjeux fbshipit-source-id: b2c64d90a2a6e531a9be79b936d6a5da61a69b22
Summary: It was not possible to scroll due to overlaying (and visually not present) docs navigation layer. Fixes issue introduced in PR facebook#7669, see this [comment](facebook#7669 (comment)) Additionally, script makes sure only single target is "in" and closes any other target with "in" state. Closes facebook#7731 Differential Revision: D3344927 Pulled By: vjeux fbshipit-source-id: b2c64d90a2a6e531a9be79b936d6a5da61a69b22
It was not possible to scroll due to overlaying (and visually not present) docs navigation layer.
Fixes issue introduced in PR #7669, see this comment
Additionally, script makes sure only single target is "in" and closes any other target with "in" state.