Externalize Scheduler in noop and test bundles

I also noticed we don't need to regenerator runtime in noop anymore.
facebook · Feb 28, 2019 · 00b3c37 · 00b3c37
1 parent 1646bed
commit 00b3c37
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 44 deletions.
diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js
@@ -281,15 +281,15 @@ const bundles = [
     moduleType: RENDERER,
     entry: 'react-test-renderer',
     global: 'ReactTestRenderer',
-    externals: ['react'],
+    externals: ['react', 'scheduler', 'scheduler/unstable_mock'],
   },
 
   {
     bundleTypes: [FB_WWW_DEV, NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD],
     moduleType: NON_FIBER_RENDERER,
     entry: 'react-test-renderer/shallow',
     global: 'ReactShallowRenderer',
-    externals: ['react'],
+    externals: ['react', 'scheduler', 'scheduler/unstable_mock'],
   },
 
   /******* React Noop Renderer (used for tests) *******/
@@ -298,20 +298,7 @@ const bundles = [
     moduleType: RENDERER,
     entry: 'react-noop-renderer',
     global: 'ReactNoopRenderer',
-    externals: ['react', 'expect'],
-    // React Noop uses generators. However GCC currently
-    // breaks when we attempt to use them in the output.
-    // So we precompile them with regenerator, and include
-    // it as a runtime dependency of React Noop. In practice
-    // this isn't an issue because React Noop is only used
-    // in our tests. We wouldn't want to do this for any
-    // public package though.
-    babel: opts =>
-      Object.assign({}, opts, {
-        plugins: opts.plugins.concat([
-          require.resolve('babel-plugin-transform-regenerator'),
-        ]),
-      }),
+    externals: ['react', 'scheduler', 'scheduler/unstable_mock', 'expect'],
   },
 
   /******* React Noop Persistent Renderer (used for tests) *******/
@@ -320,20 +307,7 @@ const bundles = [
     moduleType: RENDERER,
     entry: 'react-noop-renderer/persistent',
     global: 'ReactNoopRendererPersistent',
-    externals: ['react', 'expect'],
-    // React Noop uses generators. However GCC currently
-    // breaks when we attempt to use them in the output.
-    // So we precompile them with regenerator, and include
-    // it as a runtime dependency of React Noop. In practice
-    // this isn't an issue because React Noop is only used
-    // in our tests. We wouldn't want to do this for any
-    // public package though.
-    babel: opts =>
-      Object.assign({}, opts, {
-        plugins: opts.plugins.concat([
-          require.resolve('babel-plugin-transform-regenerator'),
-        ]),
-      }),
+    externals: ['react', 'scheduler', 'expect'],
   },
 
   /******* React Noop Server Renderer (used for tests) *******/
@@ -342,20 +316,7 @@ const bundles = [
     moduleType: RENDERER,
     entry: 'react-noop-renderer/server',
     global: 'ReactNoopRendererServer',
-    externals: ['react', 'expect'],
-    // React Noop uses generators. However GCC currently
-    // breaks when we attempt to use them in the output.
-    // So we precompile them with regenerator, and include
-    // it as a runtime dependency of React Noop. In practice
-    // this isn't an issue because React Noop is only used
-    // in our tests. We wouldn't want to do this for any
-    // public package though.
-    babel: opts =>
-      Object.assign({}, opts, {
-        plugins: opts.plugins.concat([
-          require.resolve('babel-plugin-transform-regenerator'),
-        ]),
-      }),
+    externals: ['react', 'scheduler', 'expect'],
   },
 
   /******* React Reconciler *******/

diff --git a/scripts/rollup/modules.js b/scripts/rollup/modules.js
@@ -25,6 +25,7 @@ const knownGlobals = Object.freeze({
   'react-dom': 'ReactDOM',
   scheduler: 'Scheduler',
   'scheduler/tracing': 'SchedulerTracing',
+  'scheduler/unstable_mock': 'SchedulerMock',
 });
 
 // Given ['react'] in bundle externals, returns { 'react': 'React' }.