Skip to content

Commit

Permalink
Rename RootDidNotComplete to RootSuspendedAtTheShell
Browse files Browse the repository at this point in the history
  • Loading branch information
sebmarkbage committed Nov 15, 2024
1 parent d5f81b9 commit 67ad5e3
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions packages/react-reconciler/src/ReactFiberWorkLoop.js
Original file line number Diff line number Diff line change
Expand Up @@ -329,8 +329,8 @@ const RootFatalErrored = 1;
const RootErrored = 2;
const RootSuspended = 3;
const RootSuspendedWithDelay = 4;
const RootSuspendedAtTheShell = 6;
const RootCompleted = 5;
const RootDidNotComplete = 6;

// Describes where we are in the React execution stack
let executionContext: ExecutionContext = NoContext;
Expand Down Expand Up @@ -989,7 +989,7 @@ export function performWorkOnRoot(
// from the beginning.
// TODO: Refactor the exit algorithm to be less confusing. Maybe
// more branches + recursion instead of a loop. I think the only
// thing that causes it to be a loop is the RootDidNotComplete
// thing that causes it to be a loop is the RootSuspendedAtTheShell
// check. If that's true, then we don't need a loop/recursion
// at all.
continue;
Expand Down Expand Up @@ -1131,7 +1131,7 @@ function finishConcurrentRender(
}
}
// Fallthrough
case RootDidNotComplete: {
case RootSuspendedAtTheShell: {
// This is a transition, so we should exit without committing a
// placeholder and without scheduling a timeout. Delay indefinitely
// until we receive more data.
Expand Down Expand Up @@ -2139,7 +2139,7 @@ function renderRootSync(
// just yield and reset the stack when we re-enter the work loop,
// like normal.
resetWorkInProgressStack();
exitStatus = RootDidNotComplete;
exitStatus = RootSuspendedAtTheShell;
break outer;
}
case SuspendedOnImmediate:
Expand Down Expand Up @@ -2458,7 +2458,7 @@ function renderRootConcurrent(root: FiberRoot, lanes: Lanes) {
// Interrupt the current render so the work loop can switch to the
// hydration lane.
resetWorkInProgressStack();
workInProgressRootExitStatus = RootDidNotComplete;
workInProgressRootExitStatus = RootSuspendedAtTheShell;
break outer;
}
default: {
Expand Down Expand Up @@ -2966,7 +2966,7 @@ function unwindUnitOfWork(unitOfWork: Fiber, skipSiblings: boolean): void {
} while (incompleteWork !== null);

// We've unwound all the way to the root.
workInProgressRootExitStatus = RootDidNotComplete;
workInProgressRootExitStatus = RootSuspendedAtTheShell;
workInProgress = null;
}

Expand Down

0 comments on commit 67ad5e3

Please sign in to comment.