Skip to content

Commit

Permalink
Implement requestPaint in the actual scheduler (#31784)
Browse files Browse the repository at this point in the history
When implementing passive effects we did a pretty massive oversight.
While the passive effect is scheduled into its own scheduler task, the
scheduler doesn't always yield to the browser if it has time left. That
means that if you have a fast commit phase, it might try to squeeze in
the passive effects in the same frame but those then might end being
very heavy.

We had `requestPaint()` for this but that was only implemented for the
`isInputPending` experiment. It wasn't thought we needed it for the
regular scheduler because it yields "every frame" anyway - but it
doesn't yield every task. While the `isInputPending` experiment showed
that it wasn't actually any significant impact, and it was better to
keep shorter yield time anyway. Which is why we deleted the code.
Whatever small win it did see in some cases might have been actually due
to this issue rather than anything to do with `isInputPending` at all.

As you can see in #31782 we do
have this implemented in the mock scheduler and a lot of behavior that
we assert assumes that this works.

So this just implements yielding after `requestPaint` is called.

Before:

<img width="1023" alt="Screenshot 2024-12-14 at 3 40 24 PM"
src="https://github.com/user-attachments/assets/d60f4bb2-c8f8-4f91-a402-9ac25b278450"
/>

After:

<img width="1108" alt="Screenshot 2024-12-14 at 3 41 25 PM"
src="https://github.com/user-attachments/assets/170cdb90-a049-436f-9501-be3fb9bc04ca"
/>

Notice how in after the native task is split into two. It might not
always actually paint and the native scheduler might make the same
mistake and think it has enough time left but it's at least less likely
to.

We do have another way to do this. When we yield a continuation we also
yield to the native browser. This is to enable the Suspense Optimization
(currently disabled) to work. We could do the same for passive effects
and, in fact, I have a branch that does but because that requires a lot
more tests to be fixed it's a lot more invasive of a change. The nice
thing about this approach is that this is not even running in tests at
all and the tests we do have assert that this is the behavior already. 😬

DiffTrain build for [c80b336](c80b336)
  • Loading branch information
sebmarkbage committed Dec 14, 2024
1 parent 82c0c10 commit da9bea2
Show file tree
Hide file tree
Showing 40 changed files with 146 additions and 98 deletions.
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c32780eeb4c44e138d09a35da841926f512d3b07
c80b336d23aa472b5e5910268138ac0447d6ae19
2 changes: 1 addition & 1 deletion compiled/facebook-www/REVISION_TRANSFORMS
Original file line number Diff line number Diff line change
@@ -1 +1 @@
c32780eeb4c44e138d09a35da841926f512d3b07
c80b336d23aa472b5e5910268138ac0447d6ae19
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -1954,7 +1954,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -1954,7 +1954,7 @@ __DEV__ &&
exports.useTransition = function () {
return resolveDispatcher().useTransition();
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -635,4 +635,4 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/React-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ exports.useSyncExternalStore = function (
exports.useTransition = function () {
return ReactSharedInternals.H.useTransition();
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17189,10 +17189,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-classic-d1dd7fea-20241214",
version: "19.1.0-www-classic-c80b336d-20241214",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-classic-c80b336d-20241214"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -17226,7 +17226,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -16952,10 +16952,10 @@ __DEV__ &&
(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-modern-d1dd7fea-20241214",
version: "19.1.0-www-modern-c80b336d-20241214",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-modern-c80b336d-20241214"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -16989,7 +16989,7 @@ __DEV__ &&
exports.Shape = Shape;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -10825,10 +10825,10 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1500 = {
bundleType: 0,
version: "19.1.0-www-classic-d1dd7fea-20241214",
version: "19.1.0-www-classic-c80b336d-20241214",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-classic-c80b336d-20241214"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1501 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10854,4 +10854,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
6 changes: 3 additions & 3 deletions compiled/facebook-www/ReactART-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -10541,10 +10541,10 @@ var slice = Array.prototype.slice,
})(React.Component);
var internals$jscomp$inline_1479 = {
bundleType: 0,
version: "19.1.0-www-modern-d1dd7fea-20241214",
version: "19.1.0-www-modern-c80b336d-20241214",
rendererPackageName: "react-art",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-modern-c80b336d-20241214"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_1480 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand All @@ -10570,4 +10570,4 @@ exports.RadialGradient = RadialGradient;
exports.Shape = TYPES.SHAPE;
exports.Surface = Surface;
exports.Text = Text;
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -27665,11 +27665,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.1.0-www-classic-d1dd7fea-20241214" !== isomorphicReactPackageVersion)
if ("19.1.0-www-classic-c80b336d-20241214" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.1.0-www-classic-d1dd7fea-20241214\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.1.0-www-classic-c80b336d-20241214\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27712,10 +27712,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-classic-d1dd7fea-20241214",
version: "19.1.0-www-classic-c80b336d-20241214",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-classic-c80b336d-20241214"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -28322,7 +28322,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -27444,11 +27444,11 @@ __DEV__ &&
return_targetInst = null;
(function () {
var isomorphicReactPackageVersion = React.version;
if ("19.1.0-www-modern-d1dd7fea-20241214" !== isomorphicReactPackageVersion)
if ("19.1.0-www-modern-c80b336d-20241214" !== isomorphicReactPackageVersion)
throw Error(
'Incompatible React versions: The "react" and "react-dom" packages must have the exact same version. Instead got:\n - react: ' +
(isomorphicReactPackageVersion +
"\n - react-dom: 19.1.0-www-modern-d1dd7fea-20241214\nLearn more: https://react.dev/warnings/version-mismatch")
"\n - react-dom: 19.1.0-www-modern-c80b336d-20241214\nLearn more: https://react.dev/warnings/version-mismatch")
);
})();
("function" === typeof Map &&
Expand Down Expand Up @@ -27491,10 +27491,10 @@ __DEV__ &&
!(function () {
var internals = {
bundleType: 1,
version: "19.1.0-www-modern-d1dd7fea-20241214",
version: "19.1.0-www-modern-c80b336d-20241214",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-modern-c80b336d-20241214"
};
internals.overrideHookState = overrideHookState;
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
Expand Down Expand Up @@ -28101,7 +28101,7 @@ __DEV__ &&
exports.useFormStatus = function () {
return resolveDispatcher().useHostTransitionStatus();
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17282,14 +17282,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1765 = React.version;
if (
"19.1.0-www-classic-d1dd7fea-20241214" !==
"19.1.0-www-classic-c80b336d-20241214" !==
isomorphicReactPackageVersion$jscomp$inline_1765
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1765,
"19.1.0-www-classic-d1dd7fea-20241214"
"19.1.0-www-classic-c80b336d-20241214"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17307,10 +17307,10 @@ Internals.Events = [
];
var internals$jscomp$inline_2306 = {
bundleType: 0,
version: "19.1.0-www-classic-d1dd7fea-20241214",
version: "19.1.0-www-classic-c80b336d-20241214",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-classic-c80b336d-20241214"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2307 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17675,4 +17675,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -17013,14 +17013,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1755 = React.version;
if (
"19.1.0-www-modern-d1dd7fea-20241214" !==
"19.1.0-www-modern-c80b336d-20241214" !==
isomorphicReactPackageVersion$jscomp$inline_1755
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1755,
"19.1.0-www-modern-d1dd7fea-20241214"
"19.1.0-www-modern-c80b336d-20241214"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17038,10 +17038,10 @@ Internals.Events = [
];
var internals$jscomp$inline_2288 = {
bundleType: 0,
version: "19.1.0-www-modern-d1dd7fea-20241214",
version: "19.1.0-www-modern-c80b336d-20241214",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-modern-c80b336d-20241214"
};
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
var hook$jscomp$inline_2289 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
Expand Down Expand Up @@ -17406,4 +17406,4 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-profiling.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -17971,14 +17971,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1858 = React.version;
if (
"19.1.0-www-classic-d1dd7fea-20241214" !==
"19.1.0-www-classic-c80b336d-20241214" !==
isomorphicReactPackageVersion$jscomp$inline_1858
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1858,
"19.1.0-www-classic-d1dd7fea-20241214"
"19.1.0-www-classic-c80b336d-20241214"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17996,10 +17996,10 @@ Internals.Events = [
];
var internals$jscomp$inline_1860 = {
bundleType: 0,
version: "19.1.0-www-classic-d1dd7fea-20241214",
version: "19.1.0-www-classic-c80b336d-20241214",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-classic-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-classic-c80b336d-20241214"
};
enableSchedulingProfiler &&
((internals$jscomp$inline_1860.getLaneLabelMap = getLaneLabelMap),
Expand Down Expand Up @@ -18367,7 +18367,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
10 changes: 5 additions & 5 deletions compiled/facebook-www/ReactDOM-profiling.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -17701,14 +17701,14 @@ function getCrossOriginStringAs(as, input) {
}
var isomorphicReactPackageVersion$jscomp$inline_1848 = React.version;
if (
"19.1.0-www-modern-d1dd7fea-20241214" !==
"19.1.0-www-modern-c80b336d-20241214" !==
isomorphicReactPackageVersion$jscomp$inline_1848
)
throw Error(
formatProdErrorMessage(
527,
isomorphicReactPackageVersion$jscomp$inline_1848,
"19.1.0-www-modern-d1dd7fea-20241214"
"19.1.0-www-modern-c80b336d-20241214"
)
);
Internals.findDOMNode = function (componentOrElement) {
Expand All @@ -17726,10 +17726,10 @@ Internals.Events = [
];
var internals$jscomp$inline_1850 = {
bundleType: 0,
version: "19.1.0-www-modern-d1dd7fea-20241214",
version: "19.1.0-www-modern-c80b336d-20241214",
rendererPackageName: "react-dom",
currentDispatcherRef: ReactSharedInternals,
reconcilerVersion: "19.1.0-www-modern-d1dd7fea-20241214"
reconcilerVersion: "19.1.0-www-modern-c80b336d-20241214"
};
enableSchedulingProfiler &&
((internals$jscomp$inline_1850.getLaneLabelMap = getLaneLabelMap),
Expand Down Expand Up @@ -18097,7 +18097,7 @@ exports.useFormState = function (action, initialState, permalink) {
exports.useFormStatus = function () {
return ReactSharedInternals.H.useHostTransitionStatus();
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
"function" ===
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&
Expand Down
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -9158,5 +9158,5 @@ __DEV__ &&
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
})();
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-dev.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -8984,5 +8984,5 @@ __DEV__ &&
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
})();
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.classic.js
Original file line number Diff line number Diff line change
Expand Up @@ -5906,4 +5906,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.1.0-www-classic-d1dd7fea-20241214";
exports.version = "19.1.0-www-classic-c80b336d-20241214";
2 changes: 1 addition & 1 deletion compiled/facebook-www/ReactDOMServer-prod.modern.js
Original file line number Diff line number Diff line change
Expand Up @@ -5818,4 +5818,4 @@ exports.renderToString = function (children, options) {
'The server used "renderToString" which does not support Suspense. If you intended for this Suspense boundary to render the fallback content on the server consider throwing an Error somewhere within the Suspense boundary. If you intended to have the server wait for the suspended component please switch to "renderToReadableStream" which supports Suspense on the server'
);
};
exports.version = "19.1.0-www-modern-d1dd7fea-20241214";
exports.version = "19.1.0-www-modern-c80b336d-20241214";
Loading

0 comments on commit da9bea2

Please sign in to comment.