Refactor: remove useless parameter (#25923)

## Summary I was reading the source code of `ReactFiberLane.js` and I found the third parameter of the function markRootPinged was not used. So I think we can remove it. ## How did you test this change? There is no logic changed, so I think there is no need to add unit tests. So I run `yarn test` and `yarn test --prod` locally and all tests are passed. Co-authored-by: Jan Kassens <[email protected]> DiffTrain build for [afe6521](afe6521) [View git log for this commit](https://github.com/facebook/react/commits/afe6521e134178920f0523ede4c715942d8f0564)
facebook · Jan 10, 2023 · db4353c · db4353c
1 parent 6283e19
commit db4353c
Show file tree

Hide file tree

Showing 28 changed files with 158 additions and 158 deletions.
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-1253462ea48db362faad864695a172f5a56759ca
+afe6521e134178920f0523ede4c715942d8f0564
diff --git a/compiled/facebook-www/REVISION_TRANSFORMS b/compiled/facebook-www/REVISION_TRANSFORMS
@@ -1 +1 @@
-1253462ea48db362faad864695a172f5a56759ca
+afe6521e134178920f0523ede4c715942d8f0564
diff --git a/compiled/facebook-www/React-dev.classic.js b/compiled/facebook-www/React-dev.classic.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-classic-1253462ea-20230109";
+var ReactVersion = "18.3.0-www-classic-afe6521e1-20230109";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-dev.modern.js b/compiled/facebook-www/React-dev.modern.js
@@ -27,7 +27,7 @@ if (
 }
           "use strict";
 
-var ReactVersion = "18.3.0-www-modern-1253462ea-20230109";
+var ReactVersion = "18.3.0-www-modern-afe6521e1-20230109";
 
 // ATTENTION
 // When adding new symbols to this file,

diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-1253462ea-20230109";
+exports.version = "18.3.0-www-classic-afe6521e1-20230109";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-1253462ea-20230109";
+exports.version = "18.3.0-www-modern-afe6521e1-20230109";
diff --git a/compiled/facebook-www/React-profiling.classic.js b/compiled/facebook-www/React-profiling.classic.js
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-classic-1253462ea-20230109";
+exports.version = "18.3.0-www-classic-afe6521e1-20230109";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/React-profiling.modern.js b/compiled/facebook-www/React-profiling.modern.js
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
   );
 };
 exports.useTransition = useTransition;
-exports.version = "18.3.0-www-modern-1253462ea-20230109";
+exports.version = "18.3.0-www-modern-afe6521e1-20230109";
 
           /* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
 if (

diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-classic-1253462ea-20230109";
+var ReactVersion = "18.3.0-www-classic-afe6521e1-20230109";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -2232,7 +2232,7 @@ function markRootSuspended(root, suspendedLanes) {
     lanes &= ~lane;
   }
 }
-function markRootPinged(root, pingedLanes, eventTime) {
+function markRootPinged(root, pingedLanes) {
   root.pingedLanes |= root.suspendedLanes & pingedLanes;
 }
 function markRootMutableRead(root, updateLane) {

diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -69,7 +69,7 @@ function _assertThisInitialized(self) {
   return self;
 }
 
-var ReactVersion = "18.3.0-www-modern-1253462ea-20230109";
+var ReactVersion = "18.3.0-www-modern-afe6521e1-20230109";
 
 var LegacyRoot = 0;
 var ConcurrentRoot = 1;
@@ -2229,7 +2229,7 @@ function markRootSuspended(root, suspendedLanes) {
     lanes &= ~lane;
   }
 }
-function markRootPinged(root, pingedLanes, eventTime) {
+function markRootPinged(root, pingedLanes) {
   root.pingedLanes |= root.suspendedLanes & pingedLanes;
 }
 function markRootMutableRead(root, updateLane) {

diff --git a/compiled/facebook-www/ReactART-prod.classic.js b/compiled/facebook-www/ReactART-prod.classic.js
@@ -9799,19 +9799,19 @@ var slice = Array.prototype.slice,
     };
     return Text;
   })(React.Component),
-  devToolsConfig$jscomp$inline_1148 = {
+  devToolsConfig$jscomp$inline_1147 = {
     findFiberByHostInstance: function() {
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-classic-1253462ea-20230109",
+    version: "18.3.0-www-classic-afe6521e1-20230109",
     rendererPackageName: "react-art"
   };
-var internals$jscomp$inline_1319 = {
-  bundleType: devToolsConfig$jscomp$inline_1148.bundleType,
-  version: devToolsConfig$jscomp$inline_1148.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1148.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1148.rendererConfig,
+var internals$jscomp$inline_1318 = {
+  bundleType: devToolsConfig$jscomp$inline_1147.bundleType,
+  version: devToolsConfig$jscomp$inline_1147.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1147.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1147.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -9828,26 +9828,26 @@ var internals$jscomp$inline_1319 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1148.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1147.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-1253462ea-20230109"
+  reconcilerVersion: "18.3.0-next-afe6521e1-20230109"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_1320 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_1319 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_1320.isDisabled &&
-    hook$jscomp$inline_1320.supportsFiber
+    !hook$jscomp$inline_1319.isDisabled &&
+    hook$jscomp$inline_1319.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_1320.inject(
-        internals$jscomp$inline_1319
+      (rendererID = hook$jscomp$inline_1319.inject(
+        internals$jscomp$inline_1318
       )),
-        (injectedHook = hook$jscomp$inline_1320);
+        (injectedHook = hook$jscomp$inline_1319);
     } catch (err) {}
 }
 var Path = Mode$1.Path;

diff --git a/compiled/facebook-www/ReactART-prod.modern.js b/compiled/facebook-www/ReactART-prod.modern.js
@@ -9466,19 +9466,19 @@ var slice = Array.prototype.slice,
     };
     return Text;
   })(React.Component),
-  devToolsConfig$jscomp$inline_1137 = {
+  devToolsConfig$jscomp$inline_1136 = {
     findFiberByHostInstance: function() {
       return null;
     },
     bundleType: 0,
-    version: "18.3.0-www-modern-1253462ea-20230109",
+    version: "18.3.0-www-modern-afe6521e1-20230109",
     rendererPackageName: "react-art"
   };
-var internals$jscomp$inline_1310 = {
-  bundleType: devToolsConfig$jscomp$inline_1137.bundleType,
-  version: devToolsConfig$jscomp$inline_1137.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1137.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1137.rendererConfig,
+var internals$jscomp$inline_1309 = {
+  bundleType: devToolsConfig$jscomp$inline_1136.bundleType,
+  version: devToolsConfig$jscomp$inline_1136.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1136.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1136.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -9495,26 +9495,26 @@ var internals$jscomp$inline_1310 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1137.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1136.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-1253462ea-20230109"
+  reconcilerVersion: "18.3.0-next-afe6521e1-20230109"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_1311 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_1310 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_1311.isDisabled &&
-    hook$jscomp$inline_1311.supportsFiber
+    !hook$jscomp$inline_1310.isDisabled &&
+    hook$jscomp$inline_1310.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_1311.inject(
-        internals$jscomp$inline_1310
+      (rendererID = hook$jscomp$inline_1310.inject(
+        internals$jscomp$inline_1309
       )),
-        (injectedHook = hook$jscomp$inline_1311);
+        (injectedHook = hook$jscomp$inline_1310);
     } catch (err) {}
 }
 var Path = Mode$1.Path;

diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -8656,7 +8656,7 @@ function markRootSuspended(root, suspendedLanes) {
     lanes &= ~lane;
   }
 }
-function markRootPinged(root, pingedLanes, eventTime) {
+function markRootPinged(root, pingedLanes) {
   root.pingedLanes |= root.suspendedLanes & pingedLanes;
 }
 function markRootMutableRead(root, updateLane) {
@@ -42707,7 +42707,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-classic-1253462ea-20230109";
+var ReactVersion = "18.3.0-www-classic-afe6521e1-20230109";
 
 function createPortal(
   children,

diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -6824,7 +6824,7 @@ function markRootSuspended(root, suspendedLanes) {
     lanes &= ~lane;
   }
 }
-function markRootPinged(root, pingedLanes, eventTime) {
+function markRootPinged(root, pingedLanes) {
   root.pingedLanes |= root.suspendedLanes & pingedLanes;
 }
 function markRootMutableRead(root, updateLane) {
@@ -42431,7 +42431,7 @@ function createFiberRoot(
   return root;
 }
 
-var ReactVersion = "18.3.0-www-modern-1253462ea-20230109";
+var ReactVersion = "18.3.0-www-modern-afe6521e1-20230109";
 
 function createPortal(
   children,

diff --git a/compiled/facebook-www/ReactDOM-prod.classic.js b/compiled/facebook-www/ReactDOM-prod.classic.js
@@ -15551,17 +15551,17 @@ Internals.Events = [
   restoreStateIfNeeded,
   batchedUpdates$1
 ];
-var devToolsConfig$jscomp$inline_1751 = {
+var devToolsConfig$jscomp$inline_1750 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-classic-1253462ea-20230109",
+  version: "18.3.0-www-classic-afe6521e1-20230109",
   rendererPackageName: "react-dom"
 };
-var internals$jscomp$inline_2135 = {
-  bundleType: devToolsConfig$jscomp$inline_1751.bundleType,
-  version: devToolsConfig$jscomp$inline_1751.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1751.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1751.rendererConfig,
+var internals$jscomp$inline_2134 = {
+  bundleType: devToolsConfig$jscomp$inline_1750.bundleType,
+  version: devToolsConfig$jscomp$inline_1750.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1750.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1750.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -15577,26 +15577,26 @@ var internals$jscomp$inline_2135 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1751.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1750.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-1253462ea-20230109"
+  reconcilerVersion: "18.3.0-next-afe6521e1-20230109"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_2136 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_2135 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_2136.isDisabled &&
-    hook$jscomp$inline_2136.supportsFiber
+    !hook$jscomp$inline_2135.isDisabled &&
+    hook$jscomp$inline_2135.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_2136.inject(
-        internals$jscomp$inline_2135
+      (rendererID = hook$jscomp$inline_2135.inject(
+        internals$jscomp$inline_2134
       )),
-        (injectedHook = hook$jscomp$inline_2136);
+        (injectedHook = hook$jscomp$inline_2135);
     } catch (err) {}
 }
 assign(Internals, {
@@ -15826,4 +15826,4 @@ exports.unstable_renderSubtreeIntoContainer = function(
   );
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-1253462ea-20230109";
+exports.version = "18.3.0-next-afe6521e1-20230109";
diff --git a/compiled/facebook-www/ReactDOM-prod.modern.js b/compiled/facebook-www/ReactDOM-prod.modern.js
@@ -15112,17 +15112,17 @@ Internals.Events = [
   restoreStateIfNeeded,
   batchedUpdates$1
 ];
-var devToolsConfig$jscomp$inline_1719 = {
+var devToolsConfig$jscomp$inline_1718 = {
   findFiberByHostInstance: getClosestInstanceFromNode,
   bundleType: 0,
-  version: "18.3.0-www-modern-1253462ea-20230109",
+  version: "18.3.0-www-modern-afe6521e1-20230109",
   rendererPackageName: "react-dom"
 };
-var internals$jscomp$inline_2110 = {
-  bundleType: devToolsConfig$jscomp$inline_1719.bundleType,
-  version: devToolsConfig$jscomp$inline_1719.version,
-  rendererPackageName: devToolsConfig$jscomp$inline_1719.rendererPackageName,
-  rendererConfig: devToolsConfig$jscomp$inline_1719.rendererConfig,
+var internals$jscomp$inline_2109 = {
+  bundleType: devToolsConfig$jscomp$inline_1718.bundleType,
+  version: devToolsConfig$jscomp$inline_1718.version,
+  rendererPackageName: devToolsConfig$jscomp$inline_1718.rendererPackageName,
+  rendererConfig: devToolsConfig$jscomp$inline_1718.rendererConfig,
   overrideHookState: null,
   overrideHookStateDeletePath: null,
   overrideHookStateRenamePath: null,
@@ -15139,26 +15139,26 @@ var internals$jscomp$inline_2110 = {
     return null === fiber ? null : fiber.stateNode;
   },
   findFiberByHostInstance:
-    devToolsConfig$jscomp$inline_1719.findFiberByHostInstance ||
+    devToolsConfig$jscomp$inline_1718.findFiberByHostInstance ||
     emptyFindFiberByHostInstance,
   findHostInstancesForRefresh: null,
   scheduleRefresh: null,
   scheduleRoot: null,
   setRefreshHandler: null,
   getCurrentFiber: null,
-  reconcilerVersion: "18.3.0-next-1253462ea-20230109"
+  reconcilerVersion: "18.3.0-next-afe6521e1-20230109"
 };
 if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
-  var hook$jscomp$inline_2111 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
+  var hook$jscomp$inline_2110 = __REACT_DEVTOOLS_GLOBAL_HOOK__;
   if (
-    !hook$jscomp$inline_2111.isDisabled &&
-    hook$jscomp$inline_2111.supportsFiber
+    !hook$jscomp$inline_2110.isDisabled &&
+    hook$jscomp$inline_2110.supportsFiber
   )
     try {
-      (rendererID = hook$jscomp$inline_2111.inject(
-        internals$jscomp$inline_2110
+      (rendererID = hook$jscomp$inline_2110.inject(
+        internals$jscomp$inline_2109
       )),
-        (injectedHook = hook$jscomp$inline_2111);
+        (injectedHook = hook$jscomp$inline_2110);
     } catch (err) {}
 }
 exports.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED = Internals;
@@ -15334,4 +15334,4 @@ exports.unstable_flushControlled = function(fn) {
   }
 };
 exports.unstable_runWithPriority = runWithPriority;
-exports.version = "18.3.0-next-1253462ea-20230109";
+exports.version = "18.3.0-next-afe6521e1-20230109";
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		1253462ea48db362faad864695a172f5a56759ca
		afe6521e134178920f0523ede4c715942d8f0564