Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All warning calls should use %s #2870

Closed
zpao opened this issue Jan 16, 2015 · 2 comments
Closed

All warning calls should use %s #2870

zpao opened this issue Jan 16, 2015 · 2 comments

Comments

@zpao
Copy link
Member

zpao commented Jan 16, 2015

Ditto on invariant. But I think those are ok already.

@kevinold
Copy link
Contributor

@zpao I'd take this if I had a bit more detail. I looked at a few thought the codebase and couldn't understand.

kevinold added a commit to kevinold/react that referenced this issue Jan 27, 2015
jimfb added a commit that referenced this issue Jan 27, 2015
@zpao
Copy link
Member Author

zpao commented Jan 27, 2015

Thanks @kevinold!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants