Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when using React.unmountComponentAtNode on a different React instance's tree #3787

Closed
sophiebits opened this issue Apr 29, 2015 · 3 comments
Closed

Warn when using React.unmountComponentAtNode on a different React instance's tree #3787

sophiebits opened this issue Apr 29, 2015 · 3 comments
Labels
Difficulty: starter

Comments

@sophiebits
Copy link
Collaborator

We should be able to look at see if the child has a data-react-id attribute but isn't rendered by this copy of React and consequently warn.

See https://groups.google.com/forum/#!topic/reactjs/mdwfKKJ0L2Q.
@jimfb
Copy link
Contributor

jimfb commented May 1, 2015

Probably same with React.render, right? We would want to warn if you are rendering into another React's instance tree?

@sophiebits
Copy link
Collaborator Author

Sure. @crm416 had some related warnings in #2065.

@devknoll devknoll mentioned this issue May 6, 2015
Closed
ventuno pushed a commit to ventuno/react that referenced this issue Aug 10, 2016
Warn when using React.unmountComponentAtNode on a different React ins…
21b5aad 
…tance's tree

facebook#3787
@ventuno ventuno mentioned this issue Aug 10, 2016
Merged
ventuno pushed a commit to ventuno/react that referenced this issue Aug 17, 2016
Implementing recommended changes.
0287f4f 
facebook#3787
sophiebits pushed a commit that referenced this issue Aug 18, 2016
@ventuno @sophiebits
Warn if using React.unmountComponentAtNode on a different React insta…
a9e681a 
…nce's tree. (#7456)

* Warn when using React.unmountComponentAtNode on a different React instance's tree

#3787

* Adding tests.

* Implementing recommended changes.

#3787
zpao pushed a commit that referenced this issue Aug 19, 2016
@ventuno @zpao
Warn if using React.unmountComponentAtNode on a different React insta…
421bb8c 
…nce's tree. (#7456)

* Warn when using React.unmountComponentAtNode on a different React instance's tree

#3787

* Adding tests.

* Implementing recommended changes.

#3787

(cherry picked from commit a9e681a)
@gaearon
Copy link
Collaborator

gaearon commented Oct 27, 2016

Fixed in #7456.

@gaearon gaearon closed this as completed Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty: starter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Warn when using React.unmountComponentAtNode on a different React instance's tree
3 participants
@sophiebits @gaearon @jimfb